[test_vrf1_neigh_with_new_router_mac] increase socket size to receive jumbograms #5669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vboykox
force-pushed
the
vboykox/increase-sock-size-again
branch
from
07843c3
to
bd110db
Compare
|
/azp run Azure.sonic-mgmt |
|
Commenter does not have sufficient privileges for PR 5669 in repo Azure/sonic-mgmt |
vboykox
force-pushed
the
vboykox/increase-sock-size-again
branch
from
bd110db
to
ea5e0aa
Compare
|
@yejianquan please review |
… jumbogram Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>
|
@vboykox It looks safe and reasonable, but please fill in the "How did you verify/test it?" section by describing how did you test it and the test results? |
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Volodymyr Boyko volodymyrx.boiko@intel.com
Description of PR
Summary:
Fixes # (issue)
vrf test sends packets of size 9k; need to increase packet socket recv size accordingly, otherwise received packets get truncated to 4096 (default receive size)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Verified by manually checking if the packet received during test_vrf1_neigh_with_new_router_mac.
With this change it fails with:
instead of no packet received.
The reason why the test still fails and ongoing discussion in these issues:
sonic-net/SONiC#409 (comment)
sonic-net/sonic-swss#1833
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation