Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bgp_helpers] wait for swss to start when restarting bgp #5915

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

Ndancejic
Copy link
Contributor

What I did: added an assert to wait for swss to come back up after restarting
bgp

Why I did it: PR in sonic buildimage adds bgp as a dependent of swss. This was
causing PR test failures due to swss not restarting in time in vms-kvm-t1-lag
tests.

Signed-off-by: Nikola Dancejic ndancejic@microsoft.com

sonic-net/sonic-buildimage#11168 and sonic-net/sonic-buildimage#11000

What I did: added an assert to wait for swss to come back up after restarting
bgp

Why I did it: PR in sonic buildimage adds bgp as a dependent of swss. This was
causing PR test failures due to swss not restarting in time in vms-kvm-t1-lag
tests.

Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
@Ndancejic Ndancejic requested a review from a team as a code owner July 2, 2022 01:07
@Ndancejic Ndancejic requested a review from prsunny July 2, 2022 01:08
@wangxin
Copy link
Collaborator

wangxin commented Jul 5, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Ndancejic Ndancejic merged commit 95e7840 into sonic-net:master Jul 6, 2022
wangxin pushed a commit that referenced this pull request Jul 12, 2022
What I did: added an assert to wait for swss to come back up after restarting
bgp

Why I did it: PR in sonic buildimage adds bgp as a dependent of swss. This was
causing PR test failures due to swss not restarting in time in vms-kvm-t1-lag
tests.

Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants