[platform_tests]Fix psu test for mgmttstor #5968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blueve
reviewed
Jul 12, 2022
| @@ -239,6 +239,9 @@ def test_turn_on_off_psu_and_check_psustatus(duthosts, enum_rand_one_per_hwsku_h | |||
| logging.info("Start testing turn off/on PSUs") | |||
| all_outlet_status = pdu_ctrl.get_outlet_status() | |||
| pytest_require(all_outlet_status and len(all_outlet_status) >= 2, 'Skip the test, cannot get at least 2 outlet status: {}'.format(all_outlet_status)) | |||
| if tbinfo["topo"]["properties"]["configuration_properties"]["common"]["dut_type"] == "MgmtTsToR": | |||
| all_outlet_status = all_outlet_status[0:2] | |||
| logging.Info("DUT is MgmtTsToR, only the first 2 outlets are visible from DUT.") | |||
There was a problem hiding this comment.
Let's assume last 2 outlets are belong to Console Switch (not visible from DUT)
Blueve
suggested changes
Jul 12, 2022
Xichen96
changed the title
Xichen96
force-pushed
the
dev/xichenlin/fix-psu
branch
from
9a229b0
to
019fce7
Compare
added 2 commits
July 12, 2022 13:04
MgmtTsToR has 4 power outlets but only 2 is visible from the DUT. The other 2 outlets are reserved for C0 device. Signed-off-by: Xichen Lin <xichenlin@microsoft.com>
Signed-off-by: Xichen Lin <xichenlin@microsoft.com>
Xichen96
force-pushed
the
dev/xichenlin/fix-psu
branch
from
019fce7
to
8120cef
Compare
Blueve
approved these changes
Jul 13, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nhe-NV
added a commit
to nhe-NV/sonic-mgmt
that referenced
this pull request
Jul 17, 2022
tbinfo is used in the PR sonic-net#5968, but the fixture is not added in the test case function.
5 tasks
yejianquan
pushed a commit
that referenced
this pull request
Jul 18, 2022
* Fix psu test for mgmttstor MgmtTsToR has 4 power outlets but only 2 is visible from the DUT. The other 2 outlets are reserved for C0 device. Assume last 2 outlets are for C0 on MgmtTsToR Signed-off-by: Xichen Lin <xichenlin@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MgmtTsToR has 4 power outlets but only 2 is visible from the DUT. The
other 2 outlets are reserved for C0 device.
Signed-off-by: Xichen Lin xichenlin@microsoft.com
Description of PR
MgmtTsToR has 4 power outlets but only 2 is visible from the DUT. The other 2 outlets are reserved for C0 device. Before the fix, tests fail because the other 2 PSUs were turned off and DUT did not observe any change. We will exclude the other 2 outlets for MgmtTsToR devices.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Same as summary.
How did you do it?
How did you verify/test it?
Run manual tests.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation