-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test case for syslog rate limit feature #6627
Add test case for syslog rate limit feature #6627
Conversation
Change-Id: I11f29fa1a2265e2ba8c9a4ea4bac6ed2a0bb5a25
The pre-commit check detected issues in the files touched by this pull request. For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
Change-Id: Ic9ed9183f8838b240c6b7f5a4b39aefa1133507b
/azpw run Azure.sonic-mgmt |
/AzurePipelines run Azure.sonic-mgmt |
Azure Pipelines successfully started running 1 pipeline(s). |
Returns: | ||
None. | ||
""" | ||
skip_release(rand_selected_dut, ["201811", "201911", "202012", "202106", "202205"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use the conditional mark plugin to do the skipping?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not find such conditional mark plugin. Do you mean to create one? If my understanding is correct, I suppose it is good suggestion, but we should implement it in a separate PR because there are many places skip test case like this.
# Save configuration and reload, verify the configuration can be loaded | ||
logger.info('Persist syslog rate limit configuration to DB and do config reload') | ||
rand_selected_dut.command('config save -y') | ||
config_reload(rand_selected_dut) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this config_reload during test cause loganalyzer to complain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not find any complain due my test.
Hi @wangxin, i have replied to your comment, would you please check if it addressed your comment? |
@Junchao-Mellanox could we move forward merging this one now that the feature PRs are all in? or should we wait for some submodule updates? |
Change-Id: I6c99fb62ac1482283278615b12b1cd02a807b5a9
HLD: sonic-net/SONiC#1049
Change-Id: I11f29fa1a2265e2ba8c9a4ea4bac6ed2a0bb5a25
Description of PR
Add test case for syslog rate limit feature.
Summary:
test_syslog_rate_limit_container
test_syslog_rate_limit_host
Type of change
Back port request
Approach
What is the motivation for this PR?
Add test case for syslog rate limit feature
How did you do it?
Add test case for syslog rate limit feature
How did you verify/test it?
Run the test case
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation