Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202012] Update WRR test to support qos remapping #6836

Merged
merged 3 commits into from
Nov 18, 2022

Conversation

bingwang-ms
Copy link
Collaborator

Description of PR

Summary:
This PR is to backport PR #6737 into 202012 branch.
This PR is to update testQosSaiDwrr to support qos remapping scenario.
When qos remapping is enabled, the QoS map is different from before.
When the remap is enabled, we have below map

DSCP TC QUEUE
3    3    3
4    4    4
8    0    0
0    1    1
46   5    5
48   7    7

So the test script need to be updated.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

This PR is to update testQosSaiDwrr to support qos remapping scenario.

How did you do it?

Update test script to to use different testing DSCP values.

How did you verify/test it?

Verified on an Arista-7050cx3 dualtor testbed.

collected 1 item                                                                                                                                                                                      

qos/test_qos_sai.py::TestQosSai::testQosSaiDwrr[None] PASSED                                                                                                                                    [100%]

Any platform specific information?

No.

Supported testbed topology if it's a new test case?

No.

Documentation

@lgtm-com
Copy link

lgtm-com bot commented Nov 16, 2022

This pull request introduces 1 alert when merging 8b2ca12 into 87d03b2 - view on LGTM.com

new alerts:

  • 1 for Unused import

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@bingwang-ms bingwang-ms merged commit d637c7d into sonic-net:202012 Nov 18, 2022
@lgtm-com
Copy link

lgtm-com bot commented Nov 18, 2022

This pull request introduces 1 alert when merging 07c4cdc into dd35680 - view on LGTM.com

new alerts:

  • 1 for Unused import

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants