Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qos_sai] Fix qos_sai portName referenced before assignment #6865

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

vcheketx
Copy link
Contributor

Description of PR

Summary:
Fixes #6864

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

On t1-lag topo, qos_sai is failed due to portName referenced before assignment.

How did you do it?

Added definition outside of if loop.

How did you verify/test it?

Run qos/test_qos_sai.py:
qos/test_qos_sai.py::TestQosSai::testParameter[cab18-4-dut-None] PASSED

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@azure-pipelines
Copy link

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing tests/qos/qos_sai_base.py

fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/qos/qos_sai_base.py:7:1: F401 'tests.common.fixtures.ptfhost_utils.ptf_portmap_file' imported but unused
tests/qos/qos_sai_base.py:10:1: F401 'tests.common.dualtor.dual_tor_utils.upper_tor_host' imported but unused
tests/qos/qos_sai_base.py:10:1: F401 'tests.common.dualtor.dual_tor_utils.lower_tor_host' imported but unused
tests/qos/qos_sai_base.py:10:1: F401 'tests.common.dualtor.dual_tor_utils.dualtor_ports' imported but unused
tests/qos/qos_sai_base.py:10:63: E231 missing whitespace after ','
...
[truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@msosyak msosyak merged commit 93d0888 into sonic-net:master Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[qos_sai] portName referenced before assignment on t1-lag topo
3 participants