Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support LACP testing on WAN 4 links topology #6934

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

cgangx
Copy link
Contributor

@cgangx cgangx commented Dec 1, 2022

Support WAN LACP testing on 4 links topology

Summary:

  1. Fix LACP active interface selection flapping
  2. Add ping test from neighbor to DUT via LACP

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

ICMP test overly LACP can fail due to interface selection issue on WAN 4 links topology.

How did you do it?

Shutdown neighbor's LACP

How did you verify/test it?

Re-run test cases.

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

Yes

Documentation

Copy link
Contributor

@tiejunzhang-ms tiejunzhang-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good for me!

@cgangx cgangx merged commit 4e28deb into sonic-net:master Dec 2, 2022
@cgangx cgangx deleted the cgangx/pcping branch March 9, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants