Test plan for feature Generic Hash #7524

congh-nvidia · 2023-02-21T02:27:00Z

Description of PR

Summary:
Test plan for the new feature Generic Hash.
The HLD of Generic Hash: sonic-net/SONiC#1101
The test implementation is not included in this PR, will open another PR.

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Back port request

201911
202012
202205
202305

Approach

What is the motivation for this PR?

Adding the test plan for the new feature Generic Hash.

How did you do it?

How did you verify/test it?

The test plan has already been reviewed internally.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

wangxin · 2023-02-21T02:27:51Z

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing docs/testplan/Generic-Hash-test-plan.md fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.....................................(no files to check)Skipped flake8...............................................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

liat-grozovik · 2023-04-09T09:19:00Z

@yxieca could you please help to review or assign?

yxieca · 2023-04-18T22:59:21Z

@congh-nvidia can you present this test plan in test subgroup meeting?

congh-nvidia · 2023-04-19T06:54:09Z

Hi @yxieca, could you send me the time of the next test subgroup meeting?

yxieca · 2023-04-19T15:04:04Z

Hi @yxieca, could you send me the time of the next test subgroup meeting?

@congh-nvidia please find the meeting in this calendar: https://sonic-net.github.io/SONiC/Calendar.html

liat-grozovik · 2023-06-14T14:00:15Z

@nazariig please help to review and also add the feature reviewer

liat-grozovik · 2023-06-21T16:11:58Z

/azp run Azure.sonic-mgmt

azure-pipelines · 2023-06-21T16:12:07Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2023-06-21T16:12:57Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing docs/testplan/Generic-Hash-test-plan.md fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.....................................(no files to check)Skipped flake8...............................................(no files to check)Skipped check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld · 2023-08-08T04:32:04Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing docs/testplan/Generic-Hash-test-plan.md fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.....................................(no files to check)Skipped flake8...............................................(no files to check)Skipped flake8...............................................(no files to check)Skipped check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld · 2023-08-11T07:09:55Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing docs/testplan/Generic-Hash-test-plan.md fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.....................................(no files to check)Skipped flake8...............................................(no files to check)Skipped flake8...............................................(no files to check)Skipped check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld · 2023-08-16T09:10:12Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing docs/testplan/Generic-Hash-test-plan.md fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.....................................(no files to check)Skipped flake8...............................................(no files to check)Skipped flake8...............................................(no files to check)Skipped check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

congh-nvidia · 2023-08-21T06:46:35Z

I will update the test plan for the review comments in the Aug 16th sonic-test-workgroup meeting.

liat-grozovik · 2023-08-27T08:09:56Z

@nazariig please review

Update the test plan according to the comments in the Aug 16th review meeting: 1. Remove the "doesn't support dualtor" expression. 2. Add clear steps for the lag hash cases when the tested hash field is DST_MAC, ETHERTYPE or VLAN_ID. 3. Add a new test case the cover the lag member remove/add scenario. 4. Remove the test_invalid_hash_fields for it has been covered in the sonic-utilities UT. (https://github.com/sonic-net/sonic-utilities/blob/c7c4831baf2f60c7f63166244eb07c6ab7fe8b8a/tests/hash_test.py)

mssonicbld · 2023-09-05T10:12:56Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing docs/testplan/Generic-Hash-test-plan.md fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.....................................(no files to check)Skipped flake8...............................................(no files to check)Skipped flake8...............................................(no files to check)Skipped check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

congh-nvidia · 2023-09-05T10:13:46Z

The test plan is updated according to the comments in the Aug 16th review meeting:

Removed the "doesn't support dualtor" expression.
Added clear steps for the lag hash cases when the tested hash field is DST_MAC, ETHERTYPE or VLAN_ID.
Added a new test case the cover the lag member remove/add scenario.
Removed the test case "test_invalid_hash_fields" for it has been covered in the sonic-utilities UT. (https://github.com/sonic-net/sonic-utilities/blob/c7c4831baf2f60c7f63166244eb07c6ab7fe8b8a/tests/hash_test.py)

Trim the trailing white line.

mssonicbld · 2023-09-22T03:11:21Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing docs/testplan/Generic-Hash-test-plan.md fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.....................................(no files to check)Skipped flake8...............................................(no files to check)Skipped flake8...............................................(no files to check)Skipped check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld · 2023-09-22T03:17:41Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing docs/testplan/Generic-Hash-test-plan.md fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.....................................(no files to check)Skipped flake8...............................................(no files to check)Skipped flake8...............................................(no files to check)Skipped check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

congh-nvidia · 2023-09-22T03:21:52Z

Hi @yxieca, the pre-commit keeps complaining about the trailing whitespace, but I can't find where it is. Is it auto-fixed by the pre-commit? How can I make the checker pass?
Thanks!

congh-nvidia · 2023-09-22T03:22:54Z

@nazariig please review

@nazariig Please review and approve the test plan, it is updated after the review meeting. Thanks.

yxieca · 2023-09-25T16:41:41Z

Hi @yxieca, the pre-commit keeps complaining about the trailing whitespace, but I can't find where it is. Is it auto-fixed by the pre-commit? How can I make the checker pass? Thanks!

@congh-nvidia this is a standalone file, have you search for " $" or "\t$" with vim? Or similar use similar method with other editors?

Remove the trailing whitespaces.

liat-grozovik · 2023-10-10T16:57:47Z

As no feedback for sonic test group community and feature owner has approved, moving a head with merging the test plan.

Create Generic-Hash-test-plan.md

3527674

congh-nvidia requested review from wangxin and yxieca as code owners February 21, 2023 02:27

congh-nvidia changed the title ~~Create Generic-Hash-test-plan.md~~ Test plan for feature Generic Hash Feb 21, 2023

yxieca requested a review from bingwang-ms April 18, 2023 22:58

congh-nvidia marked this pull request as draft April 27, 2023 05:59

nazariig mentioned this pull request Jun 14, 2023

Generic Hash HLD sonic-net/SONiC#1101

Merged

nazariig requested review from liat-grozovik and volodymyrsamotiy June 14, 2023 15:05

nazariig added the Test Plan label Jun 14, 2023

liat-grozovik requested a review from nazariig June 21, 2023 16:11

congh-nvidia marked this pull request as ready for review July 25, 2023 06:06

Update Generic-Hash-test-plan.md

63506ff

Update Generic-Hash-test-plan.md

ac02934

Update Generic-Hash-test-plan.md

e3c4666

roy-sror approved these changes Sep 3, 2023

View reviewed changes

Update Generic-Hash-test-plan.md

ba45a6d

Trim the trailing white line.

Update Generic-Hash-test-plan.md

d132d66

nazariig approved these changes Sep 25, 2023

View reviewed changes

Update Generic-Hash-test-plan.md

cf20744

Remove the trailing whitespaces.

liat-grozovik approved these changes Oct 10, 2023

View reviewed changes

liat-grozovik merged commit 40e10c4 into sonic-net:master Oct 10, 2023
11 checks passed

congh-nvidia deleted the generic_hash_testplan branch October 17, 2024 02:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test plan for feature Generic Hash #7524

Test plan for feature Generic Hash #7524

congh-nvidia commented Feb 21, 2023 •

edited

Loading

wangxin commented Feb 21, 2023

liat-grozovik commented Apr 9, 2023

yxieca commented Apr 18, 2023

congh-nvidia commented Apr 19, 2023

yxieca commented Apr 19, 2023

liat-grozovik commented Jun 14, 2023

liat-grozovik commented Jun 21, 2023

azure-pipelines bot commented Jun 21, 2023

mssonicbld commented Jun 21, 2023

mssonicbld commented Aug 8, 2023

mssonicbld commented Aug 11, 2023

mssonicbld commented Aug 16, 2023

congh-nvidia commented Aug 21, 2023

liat-grozovik commented Aug 27, 2023

mssonicbld commented Sep 5, 2023

congh-nvidia commented Sep 5, 2023

mssonicbld commented Sep 22, 2023

mssonicbld commented Sep 22, 2023

congh-nvidia commented Sep 22, 2023

congh-nvidia commented Sep 22, 2023

yxieca commented Sep 25, 2023

liat-grozovik commented Oct 10, 2023

Test plan for feature Generic Hash #7524

Test plan for feature Generic Hash #7524

Conversation

congh-nvidia commented Feb 21, 2023 • edited Loading

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

wangxin commented Feb 21, 2023

liat-grozovik commented Apr 9, 2023

yxieca commented Apr 18, 2023

congh-nvidia commented Apr 19, 2023

yxieca commented Apr 19, 2023

liat-grozovik commented Jun 14, 2023

liat-grozovik commented Jun 21, 2023

azure-pipelines bot commented Jun 21, 2023

mssonicbld commented Jun 21, 2023

mssonicbld commented Aug 8, 2023

mssonicbld commented Aug 11, 2023

mssonicbld commented Aug 16, 2023

congh-nvidia commented Aug 21, 2023

liat-grozovik commented Aug 27, 2023

mssonicbld commented Sep 5, 2023

congh-nvidia commented Sep 5, 2023

mssonicbld commented Sep 22, 2023

mssonicbld commented Sep 22, 2023

congh-nvidia commented Sep 22, 2023

congh-nvidia commented Sep 22, 2023

yxieca commented Sep 25, 2023

liat-grozovik commented Oct 10, 2023

congh-nvidia commented Feb 21, 2023 •

edited

Loading