Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fdb_mac_expire.yml]: FDB MAC Expire test case. #785

Merged
merged 10 commits into from
Jun 26, 2019
Merged

[fdb_mac_expire.yml]: FDB MAC Expire test case. #785

merged 10 commits into from
Jun 26, 2019

Conversation

praveen-li
Copy link

@praveen-li praveen-li commented Jan 18, 2019 •
edited
Loading

[fdb_mac_expire.yml]: FDB MAC Expire test case.
[fdb_mac_expire_test.py]: PTF helper to add Mac in L2 table.
[fdb.yml]: include fdb_mac_expire.yml.

This test case verifies that MAC expires within 10 mins if traffic
is not flowing using it.

Signed-off-by: Praveen Chaudharypchaudhary@linkedin.com

Description of PR

Test Case for sonic-net/sonic-buildimage#2365

Summary:
Added new file fdb_mac_expire.yml to keep FDB MAC Expire test case separate.
[fdb_mac_expire_test.py]: PTF helper to add dummy Macs in L2 table. I used separate ptf file to generate traffic for dummy mac.
[fdb.yml]: include fdb_mac_expire.yml. I included fdb_mac_expire.yml with condition when parameter run_fdb_mac_expire is set to True.

Fixes # (issue)

Type of change

  • [] Bug fix
  • [] Testbed and Framework(new/improvement)
  • [.] Test case(new/improvement)

Approach

How did you do it?

Added new file fdb_mac_expire.yml to keep FDB MAC Expire test case separate.
[fdb_mac_expire_test.py]: PTF helper to add Mac in L2 table. I used separate ptf file to generate traffic for dummy mac.
[fdb.yml]: include fdb_mac_expire.yml. I included fdb_mac_expire.yml with condition when parameter run_fdb_mac_expire is set to True.

How did you verify/test it?

Results:
Had T0 FDB run:
Snippet from Run:

TASK [test : Include fdb_mac_expire.yml] ***************************************

Friday 18 January 2019  19:48:31 +0000 (0:00:00.084)       0:00:29.393 ********

included: /var/jenkins/sonic-mgmt/ansible/roles/test/tasks/fdb_mac_expire.yml for falco-test-dut01


TASK [test : clear fdb all] ****************************************************

Friday 18 January 2019  19:48:32 +0000 (0:00:00.678)       0:00:30.071 ********

changed: [falco-test-dut01]


TASK [test : set dummy mac prefix to look for in mac table] ********************

Friday 18 January 2019  19:48:33 +0000 (0:00:00.959)       0:00:31.031 ********

ok: [falco-test-dut01]


TASK [test : check entries in mac table before adding dummy mac] ***************

Friday 18 January 2019  19:48:33 +0000 (0:00:00.180)       0:00:31.211 ********

changed: [falco-test-dut01]


TASK [test : debug] ************************************************************Friday 18 January 2019  19:48:34 +0000 (0:00:01.208)       0:00:32.419 ********

ok: [falco-test-dut01] => {
    "msg": "0"
}


TASK [test : Start PTF runner] *************************************************

Friday 18 January 2019  19:48:35 +0000 (0:00:00.166)       0:00:32.585 ********

included: /var/jenkins/sonic-mgmt/ansible/roles/test/tasks/ptf_runner.yml for falco-test-dut01


TASK [test : fail] *************************************************************

Friday 18 January 2019  19:48:35 +0000 (0:00:00.417)       0:00:33.003 ********

skipping: [falco-test-dut01]


TASK [test : PTF Test - FDB Mac Expire test] ***********************************

Friday 18 January 2019  19:48:35 +0000 (0:00:00.194)       0:00:33.198 ********

ok: [falco-test-dut01] => {
    "msg": "ptf --test-dir ptftests fdb_mac_expire_test.FdbMacExpireTest   --platform-dir ptftests  --platform remote  -t \"testbed_type='t0';router_mac='00:e0:ec:5a:7c:ac';fdb_info='/root/fdb_info.txt';dummy_mac_prefix='00:11:22:33:44'\"  --relax --debug info --log-file /tmp/fdb_mac_expire_test.FdbMacExpireTest.2019-01-18-19:48:35.log  --disable-vxlan --disable-geneve --disable-erspan --disable-mpls --disable-nvgre 2>&1"
}


TASK [test : command] **********************************************************

Friday 18 January 2019  19:48:35 +0000 (0:00:00.266)       0:00:33.464 ********

changed: [falco-test-dut01 -> 172.25.11.190]


TASK [test : debug] ************************************************************

Friday 18 January 2019  19:48:37 +0000 (0:00:01.357)       0:00:34.822 ********

ok: [falco-test-dut01] => {
    "out.stdout_lines": [
        "WARNING: No route found for IPv6 destination :: (no default route?)",
        "fdb_mac_expire_test.FdbMacExpireTest ... ok",
        "",
        "----------------------------------------------------------------------",
        "Ran 1 test in 0.018s",
        "",
        "OK"
    ]
}
TASK [test : fail] *************************************************************

Friday 18 January 2019  19:48:37 +0000 (0:00:00.252)       0:00:35.075 ********

skipping: [falco-test-dut01]


TASK [test : check entries in mac table after adding dummy mac] ****************

Friday 18 January 2019  19:48:37 +0000 (0:00:00.190)       0:00:35.266 ********

changed: [falco-test-dut01]


TASK [test : debug] ************************************************************

Friday 18 January 2019  19:48:38 +0000 (0:00:01.136)       0:00:36.402 ********

ok: [falco-test-dut01] => {
    "msg": {
        "changed": true,
        "cmd": "show mac | grep 00:11:22:33:44 | wc -l",
        "delta": "0:00:00.757353",
        "end": "2019-01-18 19:48:46.947363",
        "failed": false,
        "failed_when_result": false,
        "rc": 0,
        "start": "2019-01-18 19:48:46.190010",
        "stderr": "",
        "stdout": "1",        "stdout_lines": [
            "1"
        ],
        "warnings": []
    }
}


TASK [test : wait for 300 secs] ************************************************

Friday 18 January 2019  19:48:38 +0000 (0:00:00.108)       0:00:36.510 ********

Pausing for 300 seconds

(ctrl+C then 'C' = continue early, ctrl+C then 'A' = abort)

ok: [falco-test-dut01]


TASK [test : check entries in mac table after wait] ****************************

Friday 18 January 2019  19:53:39 +0000 (0:05:00.121)       0:05:36.631 ********

changed: [falco-test-dut01]


TASK [test : debug] ************************************************************

Friday 18 January 2019  19:53:40 +0000 (0:00:01.256)       0:05:37.888 ********
ok: [falco-test-dut01] => {
    "msg": {
        "changed": true,
        "cmd": "show mac | grep 00:11:22:33:44 | wc -l",
        "delta": "0:00:00.769846",
        "end": "2019-01-18 19:53:48.449176",
        "rc": 0,
        "start": "2019-01-18 19:53:47.679330",
        "stderr": "",
        "stdout": "1",
        "stdout_lines": [
            "1"
        ],
        "warnings": []
    }
}


TASK [test : check in mac table after 300 secs to find exact time (300-600 secs)] ***

Friday 18 January 2019  19:53:40 +0000 (0:00:00.107)       0:05:37.995 ********

skipping: [falco-test-dut01]


TASK [test : fail] *************************************************************

Friday 18 January 2019  19:53:40 +0000 (0:00:00.128)       0:05:38.124 ********

skipping: [falco-test-dut01]

TASK [test : debug] ************************************************************

Friday 18 January 2019  19:53:40 +0000 (0:00:00.202)       0:05:38.327 ********

skipping: [falco-test-dut01]


TASK [test : debug] ************************************************************

Friday 18 January 2019  19:53:40 +0000 (0:00:00.115)       0:05:38.442 ********

ok: [falco-test-dut01] => {
    "msg": "MAC Entires are Cleared around 300secs."
}


TASK [test : clear fdb all] ****************************************************

Friday 18 January 2019  19:53:41 +0000 (0:00:00.151)       0:05:38.594 ********

changed: [falco-test-dut01]


TASK [test : do basic sanity check after each test] ****************************

Friday 18 January 2019  19:53:41 +0000 (0:00:00.920)       0:05:39.515 ********

included: /var/jenkins/sonic-mgmt/ansible/roles/test/tasks/base_sanity.yml for falco-test-dut01


TASK [test : Get process information in syncd docker] **************************

Friday 18 January 2019  19:53:42 +0000 (0:00:00.690)       0:05:40.205 ********

changed: [falco-test-dut01]


TASK [test : debug] ************************************************************

Friday 18 January 2019  19:53:43 +0000 (0:00:00.600)       0:05:40.806 ********

ok: [falco-test-dut01] => {
    "ps_out.stdout_lines": [
        "root        20  0.0  0.0  41584  2740 ?        Sl   18:51   0:00 /usr/bin/dsserve /usr/bin/syncd --diag -p /etc/sai.d/sai.profile",
        "root        30 12.2  4.7 1065684 193832 ?      Sl   18:51   7:36 /usr/bin/syncd --diag -p /etc/sai.d/sai.profile",
        "root        51  0.0  5.0 759364 202260 ?       S    18:51   0:02 /usr/bin/syncd --diag -p /etc/sai.d/sai.profile"
    ]
}


TASK [test : Get orchagent process information] ********************************

Friday 18 January 2019  19:53:43 +0000 (0:00:00.102)       0:05:40.908 ********

changed: [falco-test-dut01]



……………………….
………………
Friday 18 January 2019  19:53:55 +0000 (0:00:00.071)       0:05:52.710 ********

===============================================================================

TASK: test : wait for 300 secs ---------------------------------------- 300.12s

TASK: setup ------------------------------------------------------------- 5.78s

TASK: test : Get interface facts ---------------------------------------- 5.26s

TASK: test : Get interface facts ---------------------------------------- 5.21s

TASK: test : Copy tests to PTF ------------------------------------------ 3.72s

TASK: test : Verify port channel interfaces are up correctly ------------ 1.83s

TASK: test : gather system version information -------------------------- 1.40s

TASK: test : command ---------------------------------------------------- 1.36s

TASK: test : check entries in mac table after wait ---------------------- 1.26s

TASK: test : check entries in mac table before adding dummy mac --------- 1.21s

TASK: test : Verify port channel interfaces are up correctly ------------ 1.15s
TASK: test : check entries in mac table after adding dummy mac ---------- 1.14s

TASK: test : clear fdb all ---------------------------------------------- 0.96s

TASK: test : validate all interfaces are up after test ------------------ 0.94s

TASK: test : clear fdb all ---------------------------------------------- 0.92s

TASK: test : Get process information in syncd docker -------------------- 0.69s

TASK: test : do basic sanity check after each test ---------------------- 0.69s

TASK: test : Include fdb_mac_expire.yml --------------------------------- 0.68s

TASK: test : Get process information in syncd docker -------------------- 0.60s

TASK: test : run test case {{ testcases[testcase_name]['filename'] }} file --- 0.58s

Done

(82, 0)
----------------------------------------------------------------------------------------------------
Summary:
----------------------------------------------------------------------------------------------------
TestSuite: fdb       Pass: 82                   Fail: 0

----------------------------------------------------------------------------------------------------

TestCase Result Update after Changes done to address Review Comment:
snippet:

TASK [test : Gather minigraph facts about the device] ****

Thursday 10 January 2019  21:03:06 +0000 (0:00:00.101)       0:00:29.488 ** 

ok: [falco-test-dut01]


TASK [test : Copy tests to PTF] ********

Thursday 10 January 2019  21:03:07 +0000 (0:00:00.617)       0:00:30.105 ** 

ok: [falco-test-dut01 -> 172.25.11.190]


TASK [test : Copy FDB information file to PTF] *****

Thursday 10 January 2019  21:03:10 +0000 (0:00:03.259)       0:00:33.365 ** 

ok: [falco-test-dut01 -> 172.25.11.190]


TASK [test : clear fdb all] **********

Thursday 10 January 2019  21:03:10 +0000 (0:00:00.325)       0:00:33.691 ** 

changed: [falco-test-dut01]


TASK [test : set dummy mac prefix to look for in mac table] ****

Thursday 10 January 2019  21:03:12 +0000 (0:00:01.237)       0:00:34.928 ** 

ok: [falco-test-dut01]


TASK [test : check entries in mac table before adding dummy mac] ***

Thursday 10 January 2019  21:03:12 +0000 (0:00:00.111)       0:00:35.039 ** 

changed: [falco-test-dut01]


TASK [test : debug] ************

Thursday 10 January 2019  21:03:13 +0000 (0:00:01.568)       0:00:36.608 ** 

ok: [falco-test-dut01] => {
    "msg": "0"
}


TASK [test : Start PTF runner] *******

Thursday 10 January 2019  21:03:13 +0000 (0:00:00.091)       0:00:36.699 ** 

included: /var/jenkins/sonic-mgmt/ansible/roles/test/tasks/ptf_runner.yml for falco-test-dut01


TASK [test : fail] *********

Thursday 10 January 2019  21:03:14 +0000 (0:00:00.321)       0:00:37.020 ** 

skipping: [falco-test-dut01]


TASK [test : PTF Test - FDB Mac Expire test] *****

Thursday 10 January 2019  21:03:14 +0000 (0:00:00.105)       0:00:37.125 ** 

ok: [falco-test-dut01] => {
    "msg": "ptf --test-dir ptftests fdb_mac_expire_test.FdbMacExpireTest   --platform-dir ptftests  --platform remote  -t \"testbed_type='t0';router_mac='00:e0:ec:5a:7c:ac';fdb_info='/root/fdb_info.txt';dummy_mac_prefix='00:11:22:33:44'\"  --relax --debug info --log-file /tmp/fdb_mac_expire_test.FdbMacExpireTest.2019-01-10-21:03:14.log  --disable-vxlan --disable-geneve --disable-erspan --disable-mpls --disable-nvgre 2>&1"
}


TASK [test : command] **********

Thursday 10 January 2019  21:03:14 +0000 (0:00:00.170)       0:00:37.296 ** 

changed: [falco-test-dut01 -> 172.25.11.190]


TASK [test : debug] ************

Thursday 10 January 2019  21:03:15 +0000 (0:00:01.224)       0:00:38.521 ** 

ok: [falco-test-dut01] => {
    "out.stdout_lines": [
        "WARNING: No route found for IPv6 destination :: (no default route?)", 
        "fdb_mac_expire_test.FdbMacExpireTest ... ok", 
        "", 
        "----------------------------------------------------------------------", 
        "Ran 1 test in 0.012s", 
        "", 
        "OK"
    ]
}


TASK [test : fail] *********

Thursday 10 January 2019  21:03:15 +0000 (0:00:00.147)       0:00:38.668 ** 

skipping: [falco-test-dut01]


TASK [test : check entries in mac table after adding dummy mac] ****

Thursday 10 January 2019  21:03:15 +0000 (0:00:00.105)       0:00:38.773 ** 

changed: [falco-test-dut01]


TASK [test : debug] ************

Thursday 10 January 2019  21:03:17 +0000 (0:00:01.581)       0:00:40.355 ** 

ok: [falco-test-dut01] => {
    "msg": {
        "changed": true, 
        "cmd": "show mac | grep 00:11:22:33:44 | wc -l", 
        "delta": "0:00:01.164202", 
        "end": "2019-01-10 21:03:23.931254", 
        "failed": false, 
        "failed_when_result": false, 
        "rc": 0, 
        "start": "2019-01-10 21:03:22.767052", 
        "stderr": "", 
        "stdout": "1", 
        "stdout_lines": [
            "1"
        ], 
        "warnings": []
    }
}


TASK [test : wait for 303 secs] ********

Thursday 10 January 2019  21:03:17 +0000 (0:00:00.085)       0:00:40.440 ** 

Pausing for 303 seconds

(ctrl+C then 'C' = continue early, ctrl+C then 'A' = abort)

ok: [falco-test-dut01]


TASK [test : check entries in mac table after wait] ****

Thursday 10 January 2019  21:08:20 +0000 (0:05:03.084)       0:05:43.525 ** 

changed: [falco-test-dut01]


TASK [test : debug] ************

Thursday 10 January 2019  21:08:22 +0000 (0:00:01.712)       0:05:45.237 ** 

ok: [falco-test-dut01] => {
    "msg": {
        "changed": true, 
        "cmd": "show mac | grep 00:11:22:33:44 | wc -l", 
        "delta": "0:00:01.161600", 
        "end": "2019-01-10 21:08:28.820977", 
        "rc": 0, 
        "start": "2019-01-10 21:08:27.659377", 
        "stderr": "", 
        "stdout": "1", 
        "stdout_lines": [
            "1"
        ], 
        "warnings": []
    }
}


TASK [test : check in mac table after failure to find exact time (300-600 secs)] ***

Thursday 10 January 2019  21:08:22 +0000 (0:00:00.080)       0:05:45.318 ** 

FAILED - RETRYING: TASK: test : check in mac table after failure to find exact time (300-600 secs) (19 retries left). Result was: {u'changed': True, u'end': u'2019-01-10 21:08:30.486417', u'stdout': u'1', u'cmd': u'show mac | grep 00:11:22:33:44 | wc -l', u'rc': 0, u'start': u'2019-01-10 21:08:29.325817', u'stderr': u'', u'delta': u'0:00:01.160600', 'invocation': {'module_name': u'command', u'module_args': {u'creates': None, u'executable': None, u'chdir': None, u'_raw_params': u'show mac | grep 00:11:22:33:44 | wc -l', u'removes': None, u'warn': True, u'_uses_shell': True}}, 'stdout_lines': [u'1'], u'warnings': []}

FAILED - RETRYING: TASK: test : check in mac table after failure to find exact time (300-600 secs) (18 retries left). Result was: {u'changed': True, u'end': u'2019-01-10 21:08:47.002005', u'stdout': u'1', u'cmd': u'show mac | grep 00:11:22:33:44 | wc -l', u'rc': 0, u'start': u'2019-01-10 21:08:45.835631', u'stderr': u'', u'delta': u'0:00:01.166374', 'invocation': {'module_name': u'command', u'module_args': {u'creates': None, u'executable': None, u'chdir': None, u'_raw_params': u'show mac | grep 00:11:22:33:44 | wc -l', u'removes': None, u'warn': True, u'_uses_shell': True}}, 'stdout_lines': [u'1'], u'warnings': []}

FAILED - RETRYING: TASK: test : check in mac table after failure to find exact time (300-600 secs) (17 retries left). Result was: {u'changed': True, u'end': u'2019-01-10 21:09:03.513023', u'stdout': u'1', u'cmd': u'show mac | grep 00:11:22:33:44 | wc -l', u'rc': 0, u'start': u'2019-01-10 21:09:02.353425', u'stderr': u'', u'delta': u'0:00:01.159598', 'invocation': {'module_name': u'command', u'module_args': {u'creates': None, u'executable': None, u'chdir': None, u'_raw_params': u'show mac | grep 00:11:22:33:44 | wc -l', u'removes': None, u'warn': True, u'_uses_shell': True}}, 'stdout_lines': [u'1'], u'warnings': []}

FAILED - RETRYING: TASK: test : check in mac table after failure to find exact time (300-600 secs) (16 retries left). Result was: {u'changed': True, u'end': u'2019-01-10 21:09:20.030499', u'stdout': u'1', u'cmd': u'show mac | grep 00:11:22:33:44 | wc -l', u'rc': 0, u'start': u'2019-01-10 21:09:18.860738', u'stderr': u'', u'delta': u'0:00:01.169761', 'invocation': {'module_name': u'command', u'module_args': {u'creates': None, u'executable': None, u'chdir': None, u'_raw_params': u'show mac | grep 00:11:22:33:44 | wc -l', u'removes': None, u'warn': True, u'_uses_shell': True}}, 'stdout_lines': [u'1'], u'warnings': []}

FAILED - RETRYING: TASK: test : check in mac table after failure to find exact time (300-600 secs) (15 retries left). Result was: {u'changed': True, u'end': u'2019-01-10 21:09:36.547583', u'stdout': u'1', u'cmd': u'show mac | grep 00:11:22:33:44 | wc -l', u'rc': 0, u'start': u'2019-01-10 21:09:35.381684', u'stderr': u'', u'delta': u'0:00:01.165899', 'invocation': {'module_name': u'command', u'module_args': {u'creates': None, u'executable': None, u'chdir': None, u'_raw_params': u'show mac | grep 00:11:22:33:44 | wc -l', u'removes': None, u'warn': True, u'_uses_shell': True}}, 'stdout_lines': [u'1'], u'warnings': []}

FAILED - RETRYING: TASK: test : check in mac table after failure to find exact time (300-600 secs) (14 retries left). Result was: {u'changed': True, u'end': u'2019-01-10 21:09:53.062671', u'stdout': u'1', u'cmd': u'show mac | grep 00:11:22:33:44 | wc -l', u'rc': 0, u'start': u'2019-01-10 21:09:51.901323', u'stderr': u'', u'delta': u'0:00:01.161348', 'invocation': {'module_name': u'command', u'module_args': {u'creates': None, u'executable': None, u'chdir': None, u'_raw_params': u'show mac | grep 00:11:22:33:44 | wc -l', u'removes': None, u'warn': True, u'_uses_shell': True}}, 'stdout_lines': [u'1'], u'warnings': []}

FAILED - RETRYING: TASK: test : check in mac table after failure to find exact time (300-600 secs) (13 retries left). Result was: {u'changed': True, u'end': u'2019-01-10 21:10:09.581060', u'stdout': u'1', u'cmd': u'show mac | grep 00:11:22:33:44 | wc -l', u'rc': 0, u'start': u'2019-01-10 21:10:08.413343', u'stderr': u'', u'delta': u'0:00:01.167717', 'invocation': {'module_name': u'command', u'module_args': {u'creates': None, u'executable': None, u'chdir': None, u'_raw_params': u'show mac | grep 00:11:22:33:44 | wc -l', u'removes': None, u'warn': True, u'_uses_shell': True}}, 'stdout_lines': [u'1'], u'warnings': []}

FAILED - RETRYING: TASK: test : check in mac table after failure to find exact time (300-600 secs) (12 retries left). Result was: {u'changed': True, u'end': u'2019-01-10 21:10:26.100625', u'stdout': u'1', u'cmd': u'show mac | grep 00:11:22:33:44 | wc -l', u'rc': 0, u'start': u'2019-01-10 21:10:24.933232', u'stderr': u'', u'delta': u'0:00:01.167393', 'invocation': {'module_name': u'command', u'module_args': {u'creates': None, u'executable': None, u'chdir': None, u'_raw_params': u'show mac | grep 00:11:22:33:44 | wc -l', u'removes': None, u'warn': True, u'_uses_shell': True}}, 'stdout_lines': [u'1'], u'warnings': []}

FAILED - RETRYING: TASK: test : check in mac table after failure to find exact time (300-600 secs) (11 retries left). Result was: {u'changed': True, u'end': u'2019-01-10 21:10:42.635189', u'stdout': u'1', u'cmd': u'show mac | grep 00:11:22:33:44 | wc -l', u'rc': 0, u'start': u'2019-01-10 21:10:41.453279', u'stderr': u'', u'delta': u'0:00:01.181910', 'invocation': {'module_name': u'command', u'module_args': {u'creates': None, u'executable': None, u'chdir': None, u'_raw_params': u'show mac | grep 00:11:22:33:44 | wc -l', u'removes': None, u'warn': True, u'_uses_shell': True}}, 'stdout_lines': [u'1'], u'warnings': []}

changed: [falco-test-dut01]


TASK [test : fail] *********

Thursday 10 January 2019  21:10:52 +0000 (0:02:30.380)       0:08:15.699 ** 

skipping: [falco-test-dut01]


TASK [test : clear fdb all] **********

Thursday 10 January 2019  21:10:52 +0000 (0:00:00.124)       0:08:15.823 ** 

changed: [falco-test-dut01]

Test results summary after commit 9:


=============================================================================== 

TASK: test : wait for "{{fdb_aging_time}}" secs ------------------------ 60.11s

TASK: test : check in mac table after "{{fdb_aging_time}}" secs to find exact time -- 32.81s

TASK: setup ------------------------------------------------------------- 4.84s

TASK: test : Get interface facts ---------------------------------------- 4.58s

TASK: test : Get interface facts ---------------------------------------- 4.39s

TASK: test : Copy tests to PTF ------------------------------------------ 2.97s

TASK: test : Verify port channel interfaces are up correctly ------------ 1.91s

TASK: test : command ---------------------------------------------------- 1.30s

TASK: test : gather system version information -------------------------- 1.19s

TASK: test : Verify port channel interfaces are up correctly ------------ 1.07s

TASK: test : check entries in mac table before adding dummy mac --------- 1.00s

TASK: test : check entries in mac table after adding dummy mac ---------- 0.99s

TASK: test : copy current switch.json from host to docker --------------- 0.99s

TASK: test : check entries in mac table after wait ---------------------- 0.99s

TASK: test : validate all interfaces are up after test ------------------ 0.93s

TASK: test : do basic sanity check after each test ---------------------- 0.85s

TASK: test : run test case {{ testcases[testcase_name]['filename'] }} file --- 0.84s

TASK: test : sonic-clear fdb all ---------------------------------------- 0.79s

TASK: test : sonic-clear fdb all ---------------------------------------- 0.78s

TASK: test : Get process information in syncd docker -------------------- 0.64s

Done

(93, 0)
----------------------------------------------------------------------------------------------------
Summary:
----------------------------------------------------------------------------------------------------
TestSuite: fdb_mac_expire       Pass: 93                   Fail: 0

Any platform specific information?

No

Supported testbed topology if it's a new test case?

T0

Documentation

Part of FDB.
Related PR: sonic-net/sonic-buildimage#2365

[fdb_mac_expire.yml]: FDB MAC Expire test case.
c708935 
[fdb_mac_expire_test.py]: PTF helper to add Mac in L2 table.
[fdb.yml]: include fdb_mac_expire.yml.

This test case verifies that MAC expires within 10 mins if traffic
is not flowing using it.

Signed-off-by: Praveen Chaudhary<pchaudhary@linkedin.com>
@lguohan
Copy link
Contributor

lguohan commented Jan 19, 2019

we are using run test by name? need you to add into the testcases.yml

lguohan
lguohan requested changes Jan 19, 2019
View reviewed changes
Copy link
Contributor

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as comments

Praveen Chaudhary added 7 commits January 22, 2019 10:23
[fdb_mac_expire.yml]: FDB MAC Expire test case.
467ca7f 
[fdb_mac_expire_test.py]: PTF helper to add Mac in L2 table.
[testcases.yml]: include fdb_mac_expire.yml.

This test case verifies that MAC expires within 10 mins if traffic
is not flowing using it.

Signed-off-by: Praveen Chaudhary<pchaudhary@linkedin.com>
Merge remote-tracking branch 'origin/fdb_mac_expire' into fdb_mac_expire
d788e9b
Merge remote-tracking branch 'origin/fdb_mac_expire' into fdb_mac_expire
f3d571e
Merge branch 'fdb_mac_expire' of https://github.com/praveen-li/sonic-…
40f2686 
…mgmt into fdb_mac_expire
[fdb_mac_expire.yml]: Incorporate swssconfig step to set fdb_aging_ti…
23bce82 
…mer in fdb_mac_expire.yml

Signed-off-by: Praveen Chaudhary<pchaudhary@linkedin.com>
[fdb_mac_expire.yml]: minor changes in logs
0d8e795 
Signed-off-by: Praveen Chaudhary<pchaudhary@linkedin.com>
[fdb_mac_expire.yml]: minor log changes to show time correctly.
6baaf53 
Example:
"MAC Entires are Cleared within 100 secs."
instead of
"MAC Entires are Cleared within 2*50 secs."

Signed-off-by: Praveen Chaudhary<pchaudhary@linkedin.com>
prsunny
prsunny reviewed Mar 25, 2019
View reviewed changes
ansible/roles/test/tasks/fdb_mac_expire.yml Outdated Show resolved Hide resolved
ansible/roles/test/tasks/fdb_mac_expire.yml Outdated Show resolved Hide resolved
ansible/roles/test/tasks/fdb_mac_expire.yml Outdated Show resolved Hide resolved
[fdb_mac_expire.yml]: Address review comments related to sonic-clear,…
6846597 
… -it option and block-always.

Signed-off-by: Praveen Chaudhary<pchaudhary@linkedin.com>
@praveen-li
Copy link
Author

Addressed all review comments, kindly review the latest code. Thx.

@praveen-li
Copy link
Author

Kindly merge, all issues are resolved for this .Thanks.

@praveen-li
Copy link
Author

@lguohan : Kindly help in merging this one, I see all issues are resolved and it is approved by Prince. Thanks.

@praveen-li
Copy link
Author

@lguohan : Kindly help in merging this one, I see all issues are resolved and it is approved by Prince. Thanks a lot.

@qiluo-msft qiluo-msft self-requested a review June 24, 2019 21:13
qiluo-msft
qiluo-msft approved these changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issues on comments

[fdb_mac_expire.yml]: Change "sonic-clear fdb all" to "Clear FDB table".
fdb9db8 
Signed-off-by: Praveen Chaudhary<pchaudhary@linkedin.com>
@qiluo-msft qiluo-msft merged commit 6a93830 into sonic-net:master Jun 26, 2019
qiluo-msft pushed a commit that referenced this pull request Jun 27, 2019
@qiluo-msft
[fdb_mac_expire.yml]: FDB MAC Expire test case. (#785)
025376a 
* [fdb_mac_expire.yml]: FDB MAC Expire test case.
[fdb_mac_expire_test.py]: PTF helper to add Mac in L2 table.
[fdb.yml]: include fdb_mac_expire.yml.

This test case verifies that MAC expires within 10 mins if traffic
is not flowing using it.

Signed-off-by: Praveen Chaudhary<pchaudhary@linkedin.com>

* [fdb_mac_expire.yml]: FDB MAC Expire test case.
[fdb_mac_expire_test.py]: PTF helper to add Mac in L2 table.
[testcases.yml]: include fdb_mac_expire.yml.

This test case verifies that MAC expires within 10 mins if traffic
is not flowing using it.

Signed-off-by: Praveen Chaudhary<pchaudhary@linkedin.com>

* [fdb_mac_expire.yml]: Incorporate swssconfig step to set fdb_aging_timer in fdb_mac_expire.yml

Signed-off-by: Praveen Chaudhary<pchaudhary@linkedin.com>

* [fdb_mac_expire.yml]: minor changes in logs

Signed-off-by: Praveen Chaudhary<pchaudhary@linkedin.com>

* [fdb_mac_expire.yml]: minor log changes to show time correctly.
Example:
"MAC Entires are Cleared within 100 secs."
instead of
"MAC Entires are Cleared within 2*50 secs."

Signed-off-by: Praveen Chaudhary<pchaudhary@linkedin.com>

* [fdb_mac_expire.yml]: Address review comments related to sonic-clear, -it option and block-always.

Signed-off-by: Praveen Chaudhary<pchaudhary@linkedin.com>

* [fdb_mac_expire.yml]: Change "sonic-clear fdb all" to "Clear FDB table".

Signed-off-by: Praveen Chaudhary<pchaudhary@linkedin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangxin wangxin wangxin left review comments

@zhenggen-xu zhenggen-xu zhenggen-xu left review comments

@lguohan lguohan lguohan approved these changes

@qiluo-msft qiluo-msft qiluo-msft approved these changes

@prsunny prsunny prsunny approved these changes

Assignees
No one assigned
Labels
Included in 201811 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@praveen-li @lguohan @wangxin @qiluo-msft @zhenggen-xu @prsunny