Add warmboot infra for testing with a sonic neighbor #7961

saiarcot895 · 2023-04-05T23:44:15Z

Description of PR

Summary:
Fixes # (issue)

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Back port request

201911
202012
202205

Approach

What is the motivation for this PR?

Add the necessary infra to test warmboot with a sonic neighbor. Currently, it at least does the warmboot and monitors LACPDUs sent by the T0. Fastboot is not tested at all. In addition, for now, it's assumed that it will always be a sonic neighbor; code needs to be added to determine if the neighbors are sonic or Arista.

How did you do it?

How did you verify/test it?

Ran basic warm reboot test cases with sonic neighbor, and verified the output seemed right. Other types of reboot test cases such as fast reboot and SAD test cases have not been tested.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

mssonicbld · 2023-04-05T23:45:19Z

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing ansible/roles/test/files/ptftests/advanced-reboot.py Fixing ansible/roles/test/files/ptftests/host_device.py fix end of files.........................................................Passed check yaml...............................................................Passed check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 ansible/roles/test/files/ptftests/advanced-reboot.py:2:121: E501 line too long (619 > 120 characters) ansible/roles/test/files/ptftests/advanced-reboot.py:11:121: E501 line too long (163 > 120 characters) ansible/roles/test/files/ptftests/advanced-reboot.py:12:121: E501 line too long (152 > 120 characters) ansible/roles/test/files/ptftests/advanced-reboot.py:16:121: E501 line too long (122 > 120 characters) ... [truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

…d on neighbor type Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

mssonicbld · 2023-04-13T00:31:37Z

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing ansible/roles/test/files/ptftests/host_device.py fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 ansible/roles/test/files/ptftests/advanced-reboot.py:1441:121: E501 line too long (130 > 120 characters) ansible/roles/test/files/ptftests/advanced-reboot.py:1442:121: E501 line too long (130 > 120 characters) ansible/roles/test/files/ptftests/advanced-reboot.py:1587:121: E501 line too long (132 > 120 characters) ansible/roles/test/files/ptftests/advanced-reboot.py:1588:121: E501 line too long (127 > 120 characters) ansible/roles/test/files/ptftests/host_device.py:33:1: E305 expected 2 blank lines after class or function definition, found 1 ... [truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

mssonicbld · 2023-04-19T22:57:57Z

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing ansible/roles/test/files/ptftests/host_device.py fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 ansible/roles/test/files/ptftests/advanced-reboot.py:1441:121: E501 line too long (130 > 120 characters) ansible/roles/test/files/ptftests/advanced-reboot.py:1442:121: E501 line too long (130 > 120 characters) ansible/roles/test/files/ptftests/advanced-reboot.py:1587:121: E501 line too long (132 > 120 characters) ansible/roles/test/files/ptftests/advanced-reboot.py:1588:121: E501 line too long (127 > 120 characters) ansible/roles/test/files/ptftests/host_device.py:33:1: E305 expected 2 blank lines after class or function definition, found 1 ... [truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

vaibhavhd · 2023-04-20T17:07:01Z

ansible/roles/test/files/ptftests/advanced-reboot.py

@@ -924,7 +929,7 @@ def generate_bidirectional(self):
    def put_nowait(self, queue, data):
        try:
            queue.put_nowait(data)
-        except queue.Full:
+        except Queue.Full:


This looks wrong as Queue is not same as queue arg that is passed to method.

That line should have an exception type, not an instance. In my case, I got a Python error for Full being an unknown type.

vaibhavhd · 2023-04-20T17:08:14Z

ansible/roles/test/files/ptftests/advanced-reboot.py

@@ -1433,7 +1438,8 @@ def neigh_lag_status_check(self):
        Ensure there are no interface flaps after warm-boot
        """
        for neigh in self.ssh_targets:
-            self.neigh_handle = Arista(neigh, None, self.test_params)
+            self.test_params['port_channel_intf_idx'] = [x['ptf_ports'][0] for x in self.vm_dut_map if x['mgmt_addr'] == neigh][0]


x['ptf_ports'][0] will this always select first lag member, and not all?

Fixed to take all lag members.

vaibhavhd · 2023-04-20T17:10:08Z

ansible/roles/test/files/ptftests/host_device.py

+    def verify_bgp_neigh_state(self, dut=None, state="Active"):
+        raise NotImplementedError
+
+import arista 


import statements added to EOF. Please move them to top.

This is intentional, so that when arista and sonic get imported, the HostDevice class is defined. There probably is a better Pythonic way to do this though....

vaibhavhd · 2023-04-20T17:10:56Z

ansible/roles/test/files/ptftests/sonic.py

+import ptf
+from ptf.base_tests import BaseTest
+from ptf import config
+import ptf.testutils as testutils


This is not used. Also overlaps w/ from ptf.testutils import *

There are some other unused imports in this file too. Please check.

Imports cleaned up.

vaibhavhd · 2023-04-20T17:11:20Z

ansible/roles/test/files/ptftests/sonic.py

@@ -0,0 +1,618 @@
+import ptf
+from ptf.base_tests import BaseTest


Import not used

Import removed.

vaibhavhd · 2023-04-20T17:25:38Z

ansible/roles/test/files/ptftests/sonic.py

+        self.log('Checking BGP GR peer status on VM')
+        self.check_gr_peer_status(data)
+        cli_data = {}
+        #cli_data['lacp']   = self.check_series_status(data, "lacp",         "LACP session")


Why not collect lacp data?

I didn't realize that there was a command show interface portchannel that would fit well here. I'll add that in.

vaibhavhd · 2023-04-20T17:28:05Z

ansible/roles/test/files/ptftests/sonic.py

+                continue
+            log_time = datetime.datetime.strptime(str(datetime.datetime.now().year) + " " + m.group(1), "%Y %b %d %X")
+            # Python 3 version (Python 2 doesn't have timestamp():
+            #raw_data.append((log_time.timestamp(), m.group(2), m.group(3)))


We need to support testing on both Python2 and 3.

That line will work for both Python 2 and 3; if we do move to Python 3-only, then the next line could be used for conciseness (although looking at it now, that Python 3 version needs to be updated to match the current code).

vaibhavhd · 2023-04-20T17:34:07Z

ansible/roles/test/files/ptftests/sonic.py

+
+    def verify_neigh_lag_no_flap(self):
+        flap_cnt = sys.maxint
+        output = self.do_cmd('show interfaces Po1 | json')


This will not work for SONiC, right?

No, it won't. There's a fair number of things in this file that won't work for SONiC, but I've kept them for now mostly because either they're not being executed for regular warm reboot, or they don't happen to break anything in a bad way.

vaibhavhd · 2023-04-20T17:37:13Z

ansible/roles/test/files/ptftests/sonic.py

+        cli_data['lacp']   = (0, 0)
+        cli_data['bgp_v4'] = self.check_series_status(data, "bgp_route_v4", "BGP v4 routes")
+        cli_data['bgp_v6'] = self.check_series_status(data, "bgp_route_v6", "BGP v6 routes")
+        cli_data['po']     = self.check_lag_flaps("PortChannel1", log_lines, start_time)


I don't see any place where this information about lag flap is consumed and failure is raised. I might have been lost, so please point me.

It gets printed into the log file.

sonic-mgmt/ansible/roles/test/files/ptftests/advanced-reboot.py

Line 1289 in 765e836

self.cli_info[ip]['po'][1],

vaibhavhd · 2023-04-20T17:38:12Z

ansible/roles/test/files/ptftests/sonic.py

+            return 0, 0
+
+        num_lag_flaps = len([x for x in result_lag_flaps[interface] if x[1] == "DOWN"])
+        return 0, num_lag_flaps


If the first value being returned is always 0 then why return it? Just return num_lag_flaps?

I just copied the same return semantics as Arista has for their check_change_time function (it's doing the equivalent work as this function). cli_data['po'] would still need two values, since advanced-reboot.py is always reading the second value (and ignoring the first value).

Handle multiple port channel interfaces, update LACP PDU timing collection code to current version, clean up imports a bit. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

mssonicbld · 2023-04-26T00:42:59Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing ansible/roles/test/files/ptftests/host_device.py fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 ansible/roles/test/files/ptftests/advanced-reboot.py:1449:121: E501 line too long (127 > 120 characters) ansible/roles/test/files/ptftests/advanced-reboot.py:1450:121: E501 line too long (130 > 120 characters) ansible/roles/test/files/ptftests/advanced-reboot.py:1593:121: E501 line too long (129 > 120 characters) ansible/roles/test/files/ptftests/advanced-reboot.py:1594:121: E501 line too long (127 > 120 characters) ansible/roles/test/files/ptftests/host_device.py:33:1: E305 expected 2 blank lines after class or function definition, found 1 ... [truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

…hbor

mssonicbld · 2023-04-27T23:04:35Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 ansible/roles/test/files/ptftests/advanced-reboot.py:1448:121: E501 line too long (127 > 120 characters) ansible/roles/test/files/ptftests/advanced-reboot.py:1449:121: E501 line too long (130 > 120 characters) ansible/roles/test/files/ptftests/advanced-reboot.py:1592:121: E501 line too long (129 > 120 characters) ansible/roles/test/files/ptftests/advanced-reboot.py:1593:121: E501 line too long (127 > 120 characters)

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

If testing with a SONiC neighbor, fail the warmboot test if there is a port channel flap. This is in preparation for the teamd retry count feature. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

This is used on actual hardware warm-reboot tests. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

mssonicbld · 2023-05-12T01:35:31Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 ansible/roles/test/files/ptftests/sonic.py:4:1: F401 'sys' imported but unused check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

…hbor

… for a command Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

mssonicbld · 2023-05-22T20:44:56Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 ansible/roles/test/files/ptftests/sonic.py:92:9: F841 local variable 'log_first_line' is assigned to but never used check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

saiarcot895 · 2023-05-26T17:02:25Z

ansible/roles/test/files/ptftests/sonic.py

+    def verify_neigh_lag_no_flap(self):
+        # Note: this function may have false-positives (with regards to link flaps). The start time used here is
+        # the system's boot time, not the test start time, which means any LAG flaps before the start of the test
+        # would get included here.


If, on the current VM, there are link flaps prior to the test being run, this may return a false-positive. Any suggestions on fixing this?

saiarcot895 · 2023-05-26T17:03:39Z

@vaibhavhd @yxieca could you re-review this when you get a chance?

vaibhavhd

Please update description w/ details about the tests that were done to validate this change.

Why I did it This is to add support for specifying custom retry counts for LACP sessions. This is to make warmboot easier on low-storage and low-memory platforms, by allowing more than 90 seconds of downtime. How I did it How to verify it Tested manually with these cases: Verify that changing the retry count using teamdctl PortChannel101 state item set runner.retry_count 5 takes effect Verify that the retry count change actually affects when the LAG goes down by forcefully killing teamd on one side (i.e. setting the retry count to 5 causes the LAG to go down after 150 seconds) Verify that the retry count gets reset to 3 after the LAG goes down for whatever reason Verify that the retry count gets reset to 3 after some period of time (30 seconds * retry count) Test cases are in sonic-net/sonic-mgmt#7961 and sonic-net/sonic-mgmt#8152. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

…et#13453) Why I did it This is to add support for specifying custom retry counts for LACP sessions. This is to make warmboot easier on low-storage and low-memory platforms, by allowing more than 90 seconds of downtime. How I did it How to verify it Tested manually with these cases: Verify that changing the retry count using teamdctl PortChannel101 state item set runner.retry_count 5 takes effect Verify that the retry count change actually affects when the LAG goes down by forcefully killing teamd on one side (i.e. setting the retry count to 5 causes the LAG to go down after 150 seconds) Verify that the retry count gets reset to 3 after the LAG goes down for whatever reason Verify that the retry count gets reset to 3 after some period of time (30 seconds * retry count) Test cases are in sonic-net/sonic-mgmt#7961 and sonic-net/sonic-mgmt#8152. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

* Add initial framework for testing warm reboot with SONiC neighbors Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Add support for choosing between Arista and Sonic implementation based on neighbor type Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Include timestamps in log output for easier time comparisons from log Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Bug fixes for when there's no port channel flaps Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Update SONiC warm reboot test case Handle multiple port channel interfaces, update LACP PDU timing collection code to current version, clean up imports a bit. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * fixup! Update SONiC warm reboot test case Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Fix some precommit errors Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Add return in case of attempts exceeded Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Reduce to 5 attempts. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Fix pre-commit checks Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Fix more precommit issues Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Fail the warmboot test if there's a port channel flap for SONiC neighbor If testing with a SONiC neighbor, fail the warmboot test if there is a port channel flap. This is in preparation for the teamd retry count feature. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Implement verify_neigh_lag_no_flap This is used on actual hardware warm-reboot tests. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Remove unused import Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Remove unused log message, and add log when failing to get the output for a command Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Remove unused variable Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Add retry count flag for the warm-reboot command on supported images. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> --------- Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

saiarcot895 added 2 commits April 12, 2023 12:44

Add initial framework for testing warm reboot with SONiC neighbors

fa88a5a

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

Add support for choosing between Arista and Sonic implementation base…

747353d

…d on neighbor type Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

saiarcot895 force-pushed the warmboot-sonic-neighbor branch from 789b23b to 747353d Compare April 13, 2023 00:30

saiarcot895 marked this pull request as ready for review April 17, 2023 21:36

saiarcot895 requested review from vaibhavhd and yxieca April 17, 2023 21:36

saiarcot895 added 2 commits April 19, 2023 15:55

Include timestamps in log output for easier time comparisons from log

e06ef34

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

Bug fixes for when there's no port channel flaps

f65a3ca

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

vaibhavhd reviewed Apr 20, 2023

View reviewed changes

saiarcot895 added 2 commits April 25, 2023 17:39

Update SONiC warm reboot test case

17564cd

Handle multiple port channel interfaces, update LACP PDU timing collection code to current version, clean up imports a bit. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

fixup! Update SONiC warm reboot test case

44ad59f

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

saiarcot895 added 5 commits April 25, 2023 23:13

Fix some precommit errors

dd429f3

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

Add return in case of attempts exceeded

3eccb6c

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

Reduce to 5 attempts.

9e2be21

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

Fix pre-commit checks

fdd3938

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

Merge remote-tracking branch 'origin/master' into warmboot-sonic-neig…

253e76d

…hbor

saiarcot895 added 3 commits April 27, 2023 16:11

Fix more precommit issues

63ea113

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

Fail the warmboot test if there's a port channel flap for SONiC neighbor

d893a88

If testing with a SONiC neighbor, fail the warmboot test if there is a port channel flap. This is in preparation for the teamd retry count feature. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

Implement verify_neigh_lag_no_flap

eeea2c7

This is used on actual hardware warm-reboot tests. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

saiarcot895 added 2 commits May 12, 2023 15:03

Remove unused import

5aabb74

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

Merge remote-tracking branch 'origin/master' into warmboot-sonic-neig…

ef38dd0

…hbor

saiarcot895 mentioned this pull request May 18, 2023

teamd: Add support for custom retry counts for LACP sessions sonic-net/sonic-buildimage#13453

Merged

8 tasks

saiarcot895 added 2 commits May 18, 2023 14:14

Merge remote-tracking branch 'origin/master' into warmboot-sonic-neig…

36440cd

…hbor

Remove unused log message, and add log when failing to get the output…

ed90f02

… for a command Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

Remove unused variable

dbf1751

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

saiarcot895 requested a review from vaibhavhd May 22, 2023 23:33

Add retry count flag for the warm-reboot command on supported images.

526d608

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

saiarcot895 commented May 26, 2023

View reviewed changes

vaibhavhd approved these changes May 30, 2023

View reviewed changes

saiarcot895 merged commit 9bd6f0d into sonic-net:master Jun 12, 2023

saiarcot895 deleted the warmboot-sonic-neighbor branch June 12, 2023 18:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add warmboot infra for testing with a sonic neighbor #7961

Add warmboot infra for testing with a sonic neighbor #7961

saiarcot895 commented Apr 5, 2023 •

edited

Loading

mssonicbld commented Apr 5, 2023

mssonicbld commented Apr 13, 2023

mssonicbld commented Apr 19, 2023

vaibhavhd Apr 20, 2023

saiarcot895 Apr 20, 2023

vaibhavhd Apr 20, 2023

saiarcot895 Apr 26, 2023

vaibhavhd Apr 20, 2023

saiarcot895 Apr 20, 2023

vaibhavhd Apr 20, 2023

vaibhavhd Apr 20, 2023

saiarcot895 Apr 26, 2023

vaibhavhd Apr 20, 2023

saiarcot895 May 16, 2023

vaibhavhd Apr 20, 2023

saiarcot895 Apr 20, 2023

vaibhavhd Apr 20, 2023

saiarcot895 Apr 20, 2023

vaibhavhd Apr 20, 2023

saiarcot895 Apr 20, 2023

vaibhavhd Apr 20, 2023

saiarcot895 Apr 20, 2023

vaibhavhd Apr 20, 2023

saiarcot895 Apr 20, 2023

mssonicbld commented Apr 26, 2023

mssonicbld commented Apr 27, 2023

mssonicbld commented May 12, 2023

mssonicbld commented May 22, 2023

saiarcot895 May 26, 2023

saiarcot895 commented May 26, 2023

vaibhavhd left a comment

		@@ -0,0 +1,618 @@
		import ptf
		from ptf.base_tests import BaseTest

Add warmboot infra for testing with a sonic neighbor #7961

Add warmboot infra for testing with a sonic neighbor #7961

Conversation

saiarcot895 commented Apr 5, 2023 • edited Loading

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

mssonicbld commented Apr 5, 2023

mssonicbld commented Apr 13, 2023

mssonicbld commented Apr 19, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mssonicbld commented Apr 26, 2023

mssonicbld commented Apr 27, 2023

mssonicbld commented May 12, 2023

mssonicbld commented May 22, 2023

Choose a reason for hiding this comment

saiarcot895 commented May 26, 2023

vaibhavhd left a comment

Choose a reason for hiding this comment

saiarcot895 commented Apr 5, 2023 •

edited

Loading