-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IPv6][SNMP]: Remove skip of IPv6 loopback testing #8824
[IPv6][SNMP]: Remove skip of IPv6 loopback testing #8824
Conversation
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
Do you want to remove this TODO? In reply to: 1622614016 Refers to: tests/snmp/test_snmp_loopback.py:56 in 384205c. [](commit_id = 384205c, deletion_comment = False) |
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
Removed comment. This test specifically tests over loopback IPv4 and IPv6. |
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
@qiluo-msft can you review this. |
@SuvarnaMeenakshi PR conflicts with 202205 branch |
What is the motivation for this PR? SNMP over Loopback ipv6 is currently being skipped. sonic-net/sonic-buildimage#15487 -fixes snmp over ipv6. After the above fix, SNMP over Loopback and management should work. How did you do it? Remove skip of ipv6. How did you verify/test it? Test on vs testbed with single-asic image with sonic-buildimage 15487 fix. Prerequisite PRs: sonic-net/sonic-buildimage#15688 sonic-net/sonic-buildimage#15487 (cherry picked from commit bcf44a1)
Cherry-pick with conflict resolution of #8824 What is the motivation for this PR? SNMP over Loopback ipv6 is currently being skipped. sonic-net/sonic-buildimage#15487 -fixes snmp over ipv6. After the above fix, SNMP over Loopback and management should work. How did you do it? Remove skip of ipv6. How did you verify/test it? Test on vs testbed with single-asic image with sonic-buildimage 15487 fix. Prerequisite PRs: sonic-net/sonic-buildimage#15688 sonic-net/sonic-buildimage#15487 (cherry picked from commit bcf44a1)
What is the motivation for this PR? SNMP over Loopback ipv6 is currently being skipped. sonic-net/sonic-buildimage#15487 -fixes snmp over ipv6. After the above fix, SNMP over Loopback and management should work. How did you do it? Remove skip of ipv6. How did you verify/test it? Test on vs testbed with single-asic image with sonic-buildimage 15487 fix. Prerequisite PRs: sonic-net/sonic-buildimage#15688 sonic-net/sonic-buildimage#15487
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
SNMP over Loopback ipv6 is currently being skipped.
sonic-net/sonic-buildimage#15487 -fixes snmp over ipv6.
After the above fix, SNMP over Loopback and management should work.
How did you do it?
Remove skip of ipv6.
How did you verify/test it?
Test on vs testbed with single-asic image with sonic-buildimage 15487 fix.
Prerequisite PRs:
sonic-net/sonic-buildimage#15688
sonic-net/sonic-buildimage#15487
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation