Skip tests macsec tests for t0-sonic #9874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wangxin @yxieca Please could you approve and merge. |
gechiang
approved these changes
Sep 7, 2023
yejianquan
pushed a commit
that referenced
this pull request
Sep 8, 2023
…lone (#9903) What is the motivation for this PR? This is a follow up of the fix earlier made to skip macsec tests from pipeline t0-sonic via this PR : #9874 Even with this PR merged, there was still failures in one of the tests run in t0-sonic pipeline. Further debugging showed that, we have this special param, to enable macsec (as shown below) which results in macsec setup with macsec enabled links which will fail again. REF: specific_param: t0-sonic: - name: bgp/test_bgp_fact.py param: "--neighbor_type=sonic --enable_macsec --macsec_profile=128_SCI,256_XPN_SCI" <<<<<<< # all the test modules under macsec directory - name: macsec param: "--neighbor_type=sonic --enable_macsec --macsec_profile=128_SCI,256_XPN_SCI" <<<<<<<< ~ ".azure-pipelines/pr_test_scripts.yaml" line 73 of 143 --51%-- col 1 How did you do it? So idea here is to skip the test test_bgp_fact.py for t0-sonic pipeline alone. co-authorized by: jianquanye@microsoft.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the motivation for this PR?
There is a deadlock to merge this sonic-swss submodule PR: sonic-net/sonic-buildimage#16455 as it has a prerequisite to merge this PR : #9873 before that
Both PR's are dependent on each other and hence both PR merge is blocked.
How did you do it?
To fix and come out of the deadlock, solution is to skip macsec tests in t0-sonic testbed and let the sonic-mgmt PR #9873 merge . We will introduce the macsec again and let is pass for the sonic-swss submodule update PR
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation