Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IPv6][SNMP][202205]: Remove skip of IPv6 loopback testing #9972

Merged
merged 1 commit into from
Sep 15, 2023
Merged

[IPv6][SNMP][202205]: Remove skip of IPv6 loopback testing #9972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tests/common/helpers/snmp_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,8 @@ def get_snmp_output(ip, duthost, nbr, creds_all_duts, oid='.1.3.6.1.2.1.1.1.0'):
ipaddr = ipaddress.ip_address(ip)
iptables_cmd = "iptables"

# TODO : Fix snmp query over loopback v6 and remove this check and add IPv6 ACL table/rule.
if isinstance(ipaddr, ipaddress.IPv6Address):
iptables_cmd = "ip6tables"
return None

ip_tbl_rule_add = "sudo {} -I INPUT 1 -p udp --dport 161 -d {} -j ACCEPT".format(
iptables_cmd, ip)
Expand Down
6 changes: 0 additions & 6 deletions tests/snmp/test_snmp_loopback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import pytest
import ipaddress
from tests.common.helpers.snmp_helpers import get_snmp_facts, get_snmp_output
from tests.common.devices.eos import EosHost

Expand All @@ -23,14 +22,9 @@ def test_snmp_loopback(duthosts, enum_rand_one_per_hwsku_frontend_hostname, nbrh
# Get first neighbor VM information
nbr = nbrhosts[list(nbrhosts.keys())[0]]

# TODO: Fix snmp query over Management IPv6 adderess and add SNMP test over management IPv6 address.

for ip in config_facts[u'LOOPBACK_INTERFACE'][u'Loopback0']:
loip = ip.split('/')[0]
loip = ipaddress.ip_address(loip)
# TODO: Fix SNMP query over IPv6 and remove the below check.
if not isinstance(loip, ipaddress.IPv4Address):
continue
result = get_snmp_output(loip, duthost, nbr, creds_all_duts)
assert result is not None, 'No result from snmpget'
assert len(result['stdout_lines']) > 0, 'No result from snmpget'
Expand Down