Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thermalctld APIs for recording min and max temp #131

Merged
merged 3 commits into from
Nov 12, 2020

Conversation

mprabhu-nokia
Copy link
Contributor

@mprabhu-nokia mprabhu-nokia commented Oct 14, 2020

sonic-platform-base: Changes to introduce APIs for modular chassis for thermalctld

HLD: sonic-net/SONiC#646

Introducing thermal APIs to get min and max temperatures of each sensors

  • get_minimum_recorded()
  • get_maximum_recorded()

Introducing thermal APIs to get min and max temperatures of each
sensors
  - get_minimum_recorded()
  - get_maximum_recorded()
Introducing chassis APIs to check if modular chassis
  - is_modular_chassis()
@anshuv-mfst
Copy link

@judyjoseph - could you please review.

@judyjoseph
Copy link
Contributor

LGTM

@jleveque
Copy link
Contributor

Please fix conflicts.

@mprabhu-nokia
Copy link
Contributor Author

@jleveque Could you please review this as well?

@jleveque jleveque merged commit 0a13c7b into sonic-net:master Nov 12, 2020
@jleveque
Copy link
Contributor

@mprabhu-nokia: Please also add corresponding tests for these APIs to the platform API tests in the sonic-mgmt repo.

@mprabhu-nokia
Copy link
Contributor Author

@mprabhu-nokia: Please also add corresponding tests for these APIs to the platform API tests in the sonic-mgmt repo.

Will do. Appreciate quick help with the reviews and merge.

oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-platform-common that referenced this pull request Oct 25, 2024
…on (sonic-net#131)

Summary:
This PR provides replaces the logic to check mux_direction on the y_cable by checking the mux_direction register instead of actively linked and routing TOR register
Approach
added the changes in y_cable_helper.py by replacing the API

What is the motivation for this PR?
check_mux_direction is required as per design to replace the active_linked_tor_side
active_linked_tor_side -> check_mux_direction
check_mux_direction will be utlized as for establishing mux direction explicitly

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants