-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common power consumption and supply APIs for modular chassis #136
Conversation
As discussed in 10/21 sync-up mtg., LEDs are just no specific to PSUs only. |
Recommend get_status_master_led() and set_status_master_led() as optional methods as not all platform has/support this. |
Yes, these will be made optional.
Yes, these are optional. |
Please fix conflicts |
PSUd APIs for power requirement calculations get_maximum_supplied_power() - per PSU get_all_power_consumers() - per platform to get power consumers get_maximum_consumed_power() - get total consumed power per consumer get_status_master_led() - get master psu led status set_status_master_led() - set master psu led status
Addressed review-comments to move get_maxiumum_consumed_power(), get_status_master_led() and set_status_master_led() to PSU etc. This can in future be added to Fan and other peripherals
e5b9b28
to
4988e7d
Compare
Resolved conflicts. |
@Staphylo, @Junchao-Mellanox, @minionatwork: Please review again. |
@mprabhu-nokia: Please also add corresponding tests for these APIs to the platform API tests in the sonic-mgmt repo. |
Will do. |
sonic-platform-base: Changes to introduce APIs for modular chassis for power-consumption and supplied
HLD: sonic-net/SONiC#646
PSUd APIs for power requirement calculations
get_maximum_supplied_power() - per PSU
get_status_master_led() - get master psu led status. Class method.
set_status_master_led() - set master psu led status. Class method.
get_maximum_consumed_power(self) - per consumer API. Consumers are modules, Fans