-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix decode error when parsing EEPROM fields #199
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aravindmani-1
changed the title
Fix decode error when parsing EEPROM fields
Fix decode error when parsing unicode characters
Jun 16, 2021
aravindmani-1
changed the title
Fix decode error when parsing unicode characters
Fix decode error when parsing EEPROM fields
Jun 16, 2021
jleveque
approved these changes
Jun 18, 2021
andywongarista
pushed a commit
to andywongarista/sonic-platform-common
that referenced
this pull request
Jun 18, 2021
#### Description Following error is seen while parsing EEPROM fields for few transceivers. 'utf-8' codec can't decode byte 0xff in position 6: invalid start byte #### Motivation and Context EEPROM fields will not be displayed if unicode characters are not properly. E.g. Vendor Date: 20'u-tf--8'
qiluo-msft
pushed a commit
that referenced
this pull request
Jun 21, 2021
#### Description Following error is seen while parsing EEPROM fields for few transceivers. 'utf-8' codec can't decode byte 0xff in position 6: invalid start byte #### Motivation and Context EEPROM fields will not be displayed if unicode characters are not properly. E.g. Vendor Date: 20'u-tf--8'
5 tasks
lguohan
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jul 22, 2021
To include: > e168f1d 2021-07-19 pettershao-ragilenetworks: [python coverage] fix result color bar (sonic-net/sonic-platform-common#202) > 87c81de 2021-07-13 Prince George: Fix Xcvrd crash due to invalid key access in type_of_media_interface, host_electrical_interface, connector_dict (sonic-net/sonic-platform-common#206) > 4533f82 2021-06-21 ngoc-do: Add a template function that returns list of asics on module (sonic-net/sonic-platform-common#185) > 1e860c5 2021-06-18 Aravind Mani: Fix decode error when parsing EEPROM fields (sonic-net/sonic-platform-common#199) > 93641f3 2021-06-17 Sujin Kang: Unifying the platform api for get_pcie_aer_stats with PcieBase (sonic-net/sonic-platform-common#197)
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
To include: > e168f1d 2021-07-19 pettershao-ragilenetworks: [python coverage] fix result color bar (sonic-net/sonic-platform-common#202) > 87c81de 2021-07-13 Prince George: Fix Xcvrd crash due to invalid key access in type_of_media_interface, host_electrical_interface, connector_dict (sonic-net/sonic-platform-common#206) > 4533f82 2021-06-21 ngoc-do: Add a template function that returns list of asics on module (sonic-net/sonic-platform-common#185) > 1e860c5 2021-06-18 Aravind Mani: Fix decode error when parsing EEPROM fields (sonic-net/sonic-platform-common#199) > 93641f3 2021-06-17 Sujin Kang: Unifying the platform api for get_pcie_aer_stats with PcieBase (sonic-net/sonic-platform-common#197)
judyjoseph
pushed a commit
that referenced
this pull request
Aug 20, 2021
#### Description Following error is seen while parsing EEPROM fields for few transceivers. 'utf-8' codec can't decode byte 0xff in position 6: invalid start byte #### Motivation and Context EEPROM fields will not be displayed if unicode characters are not properly. E.g. Vendor Date: 20'u-tf--8'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following error is seen while parsing EEPROM fields for few transceivers.
'utf-8' codec can't decode byte 0xff in position 6: invalid start byte
Motivation and Context
EEPROM fields will not be displayed if unicode characters are not proper.
E.g. Vendor Date: 20'u-tf--8'
How Has This Been Tested?
Check sfpshow eeprom after making the change and verify the behavior.
Additional Information (Optional)
SFP_UT.txt.log