Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sff8436] Fix TXPower params offset #227

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

mad4321
Copy link
Contributor

@mad4321 mad4321 commented Nov 3, 2021

Description

The TX power values for QSFP+ sff8436 are shown the same as RX.

show int transceiver  eeprom  -d Ethernet68 | grep Power
        Extended Identifier: Power Class 4(3.5W max), CLEI present
                RX1Power: -40.0dBm
                RX2Power: -40.0dBm
                RX3Power: -2.7622dBm
                RX4Power: -40.0dBm
                TX1Power: -40.0dBm
                TX2Power: -40.0dBm
                TX3Power: -2.7622dBm
                TX4Power: -40.0dBm

Motivation and Context

It's maybe typo error, the TX offsets was the same as RX offsets.

How Has This Been Tested?

The correct values for TX and RX are shown now.

show interfaces transceiver eeprom --dom Ethernet68 | grep Power
        Extended Identifier: Power Class 4(3.5W max), CLEI present
                RX1Power: -40.0dBm
                RX2Power: -40.0dBm
                RX3Power: -2.9217dBm
                RX4Power: -40.0dBm
                TX1Power: -1.4758dBm
                TX2Power: -1.2884dBm
                TX3Power: 0.425dBm
                TX4Power: -2.5274dBm

Additional Information (Optional)

@lguohan lguohan requested a review from prgeor December 3, 2021 07:08
@prgeor prgeor merged commit 10ae99a into sonic-net:master Dec 6, 2021
@mad4321 mad4321 deleted the qsfp+_dom_tx_fix branch December 7, 2021 16:57
@mad4321 mad4321 restored the qsfp+_dom_tx_fix branch December 7, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants