[sonic_platform_base] Add sonic_sfp and sonic_eeprom to sonic_platform_base #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge from upstream master
merge from upstream
…bfolder under sonic_platform_base to avoid duplicate files
…e new subfolder under sonic_platform_base to avoid duplicate files" This reverts commit 3e741dd.
|
@jleveque could you review and approve this? thanks. |
jleveque
approved these changes
May 8, 2019
yxieca
pushed a commit
that referenced
this pull request
Jul 10, 2019
…m_base (#27) * add sonic_sfp and sonic_eeprom to sonic_platform_base * make original sonic_sfp and sonic_eeprom as symbol link to the new subfolder under sonic_platform_base to avoid duplicate files * Revert "make original sonic_sfp and sonic_eeprom as symbol link to the new subfolder under sonic_platform_base to avoid duplicate files" This reverts commit 3e741dd.
qiluo-msft
reviewed
Dec 18, 2019
| # with mapping for future reference. | ||
| # | ||
| # TODO: Refactor this to use the portconfig.py module that now | ||
| # exists as part of the sonic-config-engine package. |
There was a problem hiding this comment.
I notice the TODO is quite reasonable, and there are lots of repeated port_config parser in code base. Can we start take the action?
There was a problem hiding this comment.
This is a good time to to make the change, because there are open PRs to begin transitioning from the port_config.ini file to a new 'platform.json' file. The logic to do the parsing and also to fallback to the old port_config.ini is all in the portconfig.py module: sonic-net/sonic-buildimage#3909
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[sonic_platform_base]: Add sonic_sfp and sonic_eeprom to sonic_platform_base
Add a copy of sonic_sfp and sonic_eeprom to sonic_platform_base
Add sonic_sfp and sonic_eeprom as submodules of sonic_platform_base
Make original sonic_sfp and sonic_eeprom as symbol link to the new subfolder under sonic_platform_base to avoid duplicate files.
Signed-off-by: Kebo Liu kebol@mellanox.com