Add new reboot-cause to cover more scenarios #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kebo Liu <kebol@nvidia.com>
6 tasks
liat-grozovik
approved these changes
Apr 11, 2022
sujinmkang
approved these changes
Apr 11, 2022
6 tasks
liat-grozovik
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Apr 18, 2022
- Why I did it Implement newly added reboot causes in PR sonic-net/sonic-platform-common#277 - How I did it Map the reboot cause sysfs to the newly added reboot causes. - How to verify it manual test, check whether the reboot cause is correct after rebooting the switch in various ways. run the community reboot test to see whether the reboot cause checker is passing. Signed-off-by: Kebo Liu <kebol@nvidia.com>
This was referenced Nov 29, 2022
liat-grozovik
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Dec 5, 2022
Add new script to cover following reboot cause scenarios: BIOS - In case the BIOS upgrade process ended with failure and cause the switch to reset. CPU - Reset is initiated by SW on the CPU. it could be that SW encountered some catastrophic situation like a memory leak, eventually, the kernel reset the whole switch. Reset from ASIC - Reset which is caused by ASIC. - What is the motivation for this PR? Add test for sonic-net/sonic-platform-common#277 - How did you do it? - How did you verify/test it? Add test script for enhance reboot cause - Any platform specific information? Mellanox platforms, except for SPC1 and SIMX - Supported testbed topology if it's a new test case? Any topology
5 tasks
itamar-talmon
pushed a commit
to itamar-talmon/sonic-platform-common
that referenced
this pull request
Jan 12, 2023
- Description Add some new reboot causes to cover followinging scenarios: BIOS - In case the BIOS upgrade process ended with failure and cause the switch to reset. CPU - Reset is initiated by SW on the CPU. it could be that SW encountered some catastrophic situation like a memory leak, eventually, the kernel reset the whole switch. Push button - Reset by pushing the reset button Reset from ASIC - Reset which is caused by ASIC. Motivation and Context Add more reboot causes to cover more scenarios. - How Has This Been Tested? UT is added with the code change. Run community reboot test to see the reboot cause checker can pass. Signed-off-by: Kebo Liu <kebol@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kebo Liu kebol@nvidia.com
Description
Add some new reboot causes to cover followinging scenarios:
Motivation and Context
Add more reboot causes to cover more scenarios.
How Has This Been Tested?
UT is added with the code change.
run community reboot test to see the reboot cause checker can pass.
Additional Information (Optional)