Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eeprom] Add UT for eeprom_tlvinfo.py #292

Merged
merged 6 commits into from
Jul 16, 2022
Merged

[eeprom] Add UT for eeprom_tlvinfo.py #292

merged 6 commits into from
Jul 16, 2022

Conversation

keboliu
Copy link
Collaborator

@keboliu keboliu commented Jul 14, 2022 •
edited
Loading

Description

Add unit test cases to test eeprom_tlvinfo.py, now code coverage is 80%

Motivation and Context

There is no UT available for eeprom_tlvinfo.py previously.
Using a HEX file to mock EEPROM content. Take this mocked EEPROM as input and test the functions.

How Has This Been Tested?

sonic@sonic_slave_docker:/sonic/src/sonic-platform-common/tests$ pytest-3 eeprom_base_test.py
=========================================================================================== test session starts ============================================================================================
platform linux -- Python 3.9.2, pytest-6.0.2, py-1.10.0, pluggy-0.13.0 -- /usr/bin/python3
cachedir: .pytest_cache
rootdir: /sonic/src/sonic-platform-common-kebo, configfile: pytest.ini
plugins: pyfakefs-4.5.6, cov-2.10.1
collected 5 items                                                                                                                                                                                          

eeprom_base_test.py::TestEepromTlvinfo::test_eeprom_tlvinfo_read_api PASSED                                                                                                                          [ 20%]
eeprom_base_test.py::TestEepromTlvinfo::test_eeprom_tlvinfo_get_tlv_field PASSED                                                                                                                     [ 40%]
eeprom_base_test.py::TestEepromTlvinfo::test_eeprom_tlvinfo_set_eeprom PASSED                                                                                                                        [ 60%]
eeprom_base_test.py::TestEepromTlvinfo::test_eeprom_tlvinfo_update_eeprom_db PASSED                                                                                                                  [ 80%]
eeprom_base_test.py::TestEepromTlvinfo::test_eeprom_tlvinfo_read_eeprom_db PASSED

Additional Information (Optional)

@keboliu
Add eeprom UT with mocked syseeprom bin
1912156 
Signed-off-by: Kebo Liu <kebol@nvidia.com>
@keboliu
improve the code testability ofeeprom_tlvinfo.py
c140763 
Signed-off-by: Kebo Liu <kebol@nvidia.com>
@keboliu
Add more test cases and comments
e64b59b 
Signed-off-by: Kebo Liu <kebol@nvidia.com>
@keboliu
fix file path issue
9e9e051 
Signed-off-by: Kebo Liu <kebol@nvidia.com>
@keboliu
fix review comments
d6b349f 
Signed-off-by: Kebo Liu <kebol@nvidia.com>
@keboliu
adjust test case
e2424b2 
Signed-off-by: Kebo Liu <kebol@nvidia.com>
@keboliu keboliu requested a review from sujinmkang July 14, 2022 05:46
@sujinmkang sujinmkang merged commit 50c24a5 into sonic-net:master Jul 16, 2022
@keboliu keboliu deleted the eeprom_ut branch July 18, 2022 01:47
@dprital dprital mentioned this pull request Aug 9, 2022
Merged
7 tasks
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-platform-common that referenced this pull request Oct 25, 2024
@liuh-80
Install libyang to azure pipeline (sonic-net#292)
4b3b238 
#### Why I did it
sonic-swss-common lib will add dependency to libyang soon, so need install libyang lib to prevent build and UT break.

#### How I did it
Modify azure pipeline to install libyang in azure pipeline steps.

#### How to verify it
Pass all UT.

#### Which release branch to backport (provide reason below if selected)

#### Description for the changelog
Modify azure pipeline to install libyang in azure pipeline steps.

#### Link to config_db schema for YANG module changes

#### A picture of a cute animal (not mandatory but encouraged)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sujinmkang sujinmkang sujinmkang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keboliu @sujinmkang