Remove shell=True #313
Merged
Remove shell=True #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: maipbui <maibui@microsoft.com>
qiluo-msft
approved these changes
Sep 27, 2022
prgeor
approved these changes
Sep 28, 2022
yxieca
pushed a commit
that referenced
this pull request
Oct 3, 2022
Signed-off-by: maipbui <maibui@microsoft.com> Signed-off-by: maipbui <maibui@microsoft.com>
7 tasks
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: maipbui maibui@microsoft.com
Description
subprocess()- useshell=False, use list of strings Ref: https://semgrep.dev/docs/cheat-sheets/python-command-injection/#mitigationMotivation and Context
subprocess()- when using withshell=Trueis dangerous. Using subprocess function without a static string can lead to command injection.How Has This Been Tested?
Pass UT
tests/pcie_common_test.pyAdditional Information (Optional)