-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix get_aux_mon_type xcvr API #339
Fix get_aux_mon_type xcvr API #339
Conversation
@prgeor please review and merge |
@prgeor please review and merge |
1 similar comment
@prgeor please review and merge |
@prgeor please review and merge |
@richardyu-ms, @StormLiangMS, please review and merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmytroxIntel Is there CLI we can check if it is flat memory? Or any output in the log?
@StormLiangMS didn't find one, I just put such code snipped in sonic_platform.sfp custom plugin to check this
|
@StormLiangMS is this for 202211 release? Otherwise, this need be approved and merged by the maintainer. Suggest to revert this one. |
@zhangyanzhao , who is maintainer for this repo and file ? |
Description Add error handling to get_aux_mon_type API Motivation and Context get_aux_mon_type reads field consts.AUX_MON_TYPE in eeprom on page 1 address 145 If memory model is flat, there is no page 1 in eeprom, only 0_lower and 0_upper Here get_aux_mon_type doesn't check whether memory model is not flat, this causes errors in running xcvrd How Has This Been Tested? Tested on testbed, assured that logs of failed eeprom reading disappeared
Description Add error handling to get_aux_mon_type API Motivation and Context get_aux_mon_type reads field consts.AUX_MON_TYPE in eeprom on page 1 address 145 If memory model is flat, there is no page 1 in eeprom, only 0_lower and 0_upper Here get_aux_mon_type doesn't check whether memory model is not flat, this causes errors in running xcvrd How Has This Been Tested? Tested on testbed, assured that logs of failed eeprom reading disappeared
Description
Add error handling to get_aux_mon_type API
Motivation and Context
get_aux_mon_type reads field consts.AUX_MON_TYPE in eeprom on page 1 address 145
If memory model is flat, there is no page 1 in eeprom, only 0_lower and 0_upper
Here get_aux_mon_type doesn't check whether memory model is not flat, this causes errors in running xcvrd
How Has This Been Tested?
Tested on testbed, assured that logs of failed eeprom reading disappeared
Additional Information (Optional)