[Component]Fix test_get_firmware_update_notification fail #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erro Log:
> pytest_assert(isinstance(notif, STRING_TYPE), "Component {}: Firmware update notification appears to be incorrect from image {}".format(i, image))
E Failed: Component 0: Firmware update notification appears to be incorrect from image current
Refer to API get_firmware_update_notification header, shall return
'None' instead of None.
"""
Retrieves a notification on what should be done in order to complete
the component firmware update
Args:
image_path: A string, path to firmware image
Returns:
A string containing the component firmware update notification if required.
By default 'None' value will be used, which indicates that no actions are required
"""
…ication_output_to_string
|
@PJHsieh please check the code coverge |
The code coverage issue is resolved. |
…ication_output_to_string
PJHsieh
force-pushed
the
Revise_get_firmware_update_notification_output_to_string
branch
from
ab66ffc
to
6e575ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix test_get_firmware_update_notification fail
Motivation and Context
Erro Log:
Refer to API get_firmware_update_notification header, shall return 'None' instead of None.
"""
Retrieves a notification on what should be done in order to complete the component firmware update
Args:
image_path: A string, path to firmware image
Returns:
A string containing the component firmware update notification if required.
By default 'None' value will be used, which indicates that no actions are required
"""
How Has This Been Tested?
Run platform_tests/api/test_component.py::TestComponentApi::test_get_firmware_update_notification with no NO api implementation.
Additional Information (Optional)