Generate media key in platform sepcific way and fix cable issues #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add break to return the cable length immediately and avoid reading the junk values Ignore ASCII errors as some cables might have some junk values causing the daemon to exit
Add API to support the generation of the preemphasis key in a platform vendor dictated way instead of generic one
jemifdo
force-pushed
the
master_platform_preemphasis
branch
from
582922f
to
88a3392
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
vendor dictated way instead of generic one
junk values
the daemon to exit
How Has This Been Tested?
Verified in Celestica platform DS2000 and DS3000 with Amphenol and Molex DAC