[Thermalctld] Update thermal info to CHASSIS_STATE_DB #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a modular chassis, the thermal information from all line-cards will be updated to the global-state-db in the control-card. Additionally, minimum and maximum temperatures will be recorded. The fan control algorithm used by certain vendors will require this information.
shyam77git
reviewed
Oct 21, 2020
shyam77git
reviewed
Oct 21, 2020
shyam77git
reviewed
Oct 21, 2020
shyam77git
reviewed
Oct 27, 2020
|
@judyjoseph - could you please review. |
judyjoseph
reviewed
Nov 4, 2020
judyjoseph
reviewed
Nov 4, 2020
shyam77git
reviewed
Nov 4, 2020
mprabhu-nokia
changed the title
|
@Junchao-Mellanox: Please review, also. |
Junchao-Mellanox
approved these changes
Nov 6, 2020
jleveque
approved these changes
Nov 11, 2020
jleveque
changed the title
Merged
2 tasks
yxieca
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Mar 19, 2021
#3117) Approach What is the motivation for this PR? Add new attribute modular_chassis which will be set true if DUT is modular chassis and False for other Add support to run tests on tests/platform_tests/test_cpu_memory_usage.py, tests/platform_tests/test_port_toggle.py on T2 chassis, change test_show_chassis_module to run duts per hwsku. Add new tests to verify thermal local and global state db on VoQ chassis introduced by PRs sonic-net/sonic-swss-common#395 and sonic-net/sonic-platform-daemons#101 How did you do it? modifications to current tests and new test file as below: tests/common/devices/sonic.py Add new attribute modular_chassis which can be used to skip tests only for modular chassis if DUT is not chassis possible values for attribute are True if DUT is part of modular chassis and False if not part of modular chassis tests/platform_tests/cli/test_show_chassis_module.py change test select one dut per hwsku instead of running on all DUTs tests/platform_tests/test_cpu_memory_usage.py change rand_one_dut_hostname to enum_rand_one_per_hwsku_hostname to test per hwsku. tests/platform_tests/test_port_toggle.py change rand_one_dut_hostname to enum_rand_one_per_hwsku_hostname to test per hwsku. tests/platform_tests/test_thermal_state_db.py Add new test for t2 chassis to verify thermal data in local state db for all thermal sensors Verify global state db in supervisor has data for all sensors from all modules in chassis How did you verify/test it? Validated the modified tests against a chassis .
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
sonic-net#3117) Approach What is the motivation for this PR? Add new attribute modular_chassis which will be set true if DUT is modular chassis and False for other Add support to run tests on tests/platform_tests/test_cpu_memory_usage.py, tests/platform_tests/test_port_toggle.py on T2 chassis, change test_show_chassis_module to run duts per hwsku. Add new tests to verify thermal local and global state db on VoQ chassis introduced by PRs sonic-net/sonic-swss-common#395 and sonic-net/sonic-platform-daemons#101 How did you do it? modifications to current tests and new test file as below: tests/common/devices/sonic.py Add new attribute modular_chassis which can be used to skip tests only for modular chassis if DUT is not chassis possible values for attribute are True if DUT is part of modular chassis and False if not part of modular chassis tests/platform_tests/cli/test_show_chassis_module.py change test select one dut per hwsku instead of running on all DUTs tests/platform_tests/test_cpu_memory_usage.py change rand_one_dut_hostname to enum_rand_one_per_hwsku_hostname to test per hwsku. tests/platform_tests/test_port_toggle.py change rand_one_dut_hostname to enum_rand_one_per_hwsku_hostname to test per hwsku. tests/platform_tests/test_thermal_state_db.py Add new test for t2 chassis to verify thermal data in local state db for all thermal sensors Verify global state db in supervisor has data for all sensors from all modules in chassis How did you verify/test it? Validated the modified tests against a chassis .
vdahiya12
pushed a commit
to vdahiya12/sonic-platform-daemons
that referenced
this pull request
Apr 4, 2022
…QSFP-DD codes (sonic-net#101) - Add parser for QSFP-DD cable type. - Add dictionaries for QSFP-DD codes. Signed-off-by: Shlomi Bitton <shlomibi@mellanox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance thermalctld to write to chassis state-DB on a modular chassis
HLD: sonic-net/SONiC#646
In a modular chassis, the thermal information from all line-cards
will be updated to the chassis state-DB in the control-card.
Additionally, minimum and maximum temperatures will be recorded.
The fan control algorithm used by certain vendors will require
this information.