-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python coverage]fix result color bar #196
Merged
lguohan
merged 3 commits into
sonic-net:master
from
pettershao-ragilenetworks:fix_python_coverage_color_bar
Jul 8, 2021
Merged
[python coverage]fix result color bar #196
lguohan
merged 3 commits into
sonic-net:master
from
pettershao-ragilenetworks:fix_python_coverage_color_bar
Jul 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pettershao-ragilenetworks <pettershao@ragilenetworks.com>
jleveque
suggested changes
Jun 25, 2021
lguohan
reviewed
Jul 1, 2021
lguohan
approved these changes
Jul 8, 2021
5 tasks
qiluo-msft
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jul 15, 2021
To include: > 66e7817 2021-07-13 [pcied] Fix pcied failure to load due to 'pcied NameError: name 'self' is not defined' (sonic-net/sonic-platform-daemons#198) > 3df6757 2021-07-08 [ci] fix result color bar in the code coverage report (sonic-net/sonic-platform-daemons#196)
judyjoseph
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
To include: > 66e7817 2021-07-13 [pcied] Fix pcied failure to load due to 'pcied NameError: name 'self' is not defined' (sonic-net/sonic-platform-daemons#198) > 3df6757 2021-07-08 [ci] fix result color bar in the code coverage report (sonic-net/sonic-platform-daemons#196)
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
To include: > 66e7817 2021-07-13 [pcied] Fix pcied failure to load due to 'pcied NameError: name 'self' is not defined' (sonic-net/sonic-platform-daemons#198) > 3df6757 2021-07-08 [ci] fix result color bar in the code coverage report (sonic-net/sonic-platform-daemons#196)
vdahiya12
pushed a commit
to vdahiya12/sonic-platform-daemons
that referenced
this pull request
Apr 4, 2022
In midplane API, default method should be raise NotImplementedError not return NotImplementedError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fix python gcov warning "Please install dotnet core to enable automatic generation of Html report"
more info check: sonic-net/sonic-snmpagent#215
How I did it
install dotnet core
How to verify it