[ycabled] add more coverage to ycabled; add minor name change for vendor API CLI return key-values pairs #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fail sceanrio's Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
vdahiya12
changed the title
prgeor
reviewed
Feb 10, 2023
| @@ -2665,7 +2666,7 @@ def handle_show_ber_cmd_arg_tbl_notification(fvp, xcvrd_show_ber_cmd_arg_tbl, xc | |||
| helper_logger.log_warning("Failed to execute cli cmd get_alive_status API for port {} due to {}".format(physical_port,repr(e))) | |||
| if res is not None: | |||
| fvs_log = swsscommon.FieldValuePairs( | |||
| [("cable", str(res))]) | |||
There was a problem hiding this comment.
without this fix what was the impact?
There was a problem hiding this comment.
This will just result in executing the show CLI
$show mux cablealivestatus as
PORT ATTR HEALTH
--------- ------ --------
Ethernet0 cable True
I think preferred way would be
PORT ATTR HEALTH
--------- ------ --------
Ethernet0 cable_alive True
prgeor
approved these changes
Feb 10, 2023
qiluo-msft
pushed a commit
that referenced
this pull request
Feb 14, 2023
…dor API CLI return key-values pairs (#338) The main motivation of this PR is improve coverage of ycabled. While fixing unit test cases found an improvement to the name key-values returned to CLI, changed those names for keys as well Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com Description Motivation and Context How Has This Been Tested? Unit-Tests and running the changes on testbed. Additional Information (Optional)
yxieca
pushed a commit
that referenced
this pull request
Feb 21, 2023
…dor API CLI return key-values pairs (#338) The main motivation of this PR is improve coverage of ycabled. While fixing unit test cases found an improvement to the name key-values returned to CLI, changed those names for keys as well Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com Description Motivation and Context How Has This Been Tested? Unit-Tests and running the changes on testbed. Additional Information (Optional)
AntonHryshchuk
added a commit
to AntonHryshchuk/sonic-buildimage
that referenced
this pull request
Feb 22, 2023
Update sonic-platform-daemons submodule pointer to include the following: * f132d12 [ycabled] add more coverage to ycabled; add minor name change for vendor API CLI return key-values pairs ([sonic-net#338](sonic-net/sonic-platform-daemons#338)) Signed-off-by: AntonHryshchuk <antonh@nvidia.com>
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Feb 23, 2023
Update sonic-platform-daemons submodule pointer to include the following: * 05dd3bd Update CMIS module types for 2x100G AOC support ([sonic-net#339](sonic-net/sonic-platform-daemons#339)) * f132d12 [ycabled] add more coverage to ycabled; add minor name change for vendor API CLI return key-values pairs ([sonic-net#338](sonic-net/sonic-platform-daemons#338)) Signed-off-by: dprital <drorp@nvidia.com>
8 tasks
liat-grozovik
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Feb 23, 2023
Update sonic-platform-daemons submodule pointer to include the following: * 05dd3bd Update CMIS module types for 2x100G AOC support ([#339](sonic-net/sonic-platform-daemons#339)) * f132d12 [ycabled] add more coverage to ycabled; add minor name change for vendor API CLI return key-values pairs ([#338](sonic-net/sonic-platform-daemons#338)) Signed-off-by: dprital <drorp@nvidia.com>
lguohan
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Feb 24, 2023
Update sonic-platform-daemons submodule head to include: 05dd3bd mihirpat1 Wed Feb 22 09:19:13 2023 -0800 Update CMIS module types for 2x100G AOC support (sonic-net/sonic-platform-daemons#339) f132d12 vdahiya12 Thu Feb 9 18:01:38 2023 -0800 [ycabled] add more coverage to ycabled; add minor name change for vendor API CLI return key-values pairs (sonic-net/sonic-platform-daemons#338) Update sonic-platform-common submodule head to include: 85c20cd mihirpat1 Wed Feb 22 09:18:20 2023 -0800 Update host electrical interface for 2x100G AOC (sonic-net/sonic-platform-common#346) Signed-off-by: Mihir Patel <patelmi@microsoft.com>
StormLiangMS
pushed a commit
that referenced
this pull request
Mar 7, 2023
…dor API CLI return key-values pairs (#338) The main motivation of this PR is improve coverage of ycabled. While fixing unit test cases found an improvement to the name key-values returned to CLI, changed those names for keys as well Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com Description Motivation and Context How Has This Been Tested? Unit-Tests and running the changes on testbed. Additional Information (Optional)
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation of this PR is improve coverage of ycabled.
While fixing unit test cases found an improvement to the name key-values returned to CLI, changed those names for keys as well
Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com
Description
Motivation and Context
How Has This Been Tested?
Unit-Tests and running the changes on testbed.
Additional Information (Optional)