[ycable] add changes for correcting telemetry values for 'active-active' #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
|
Azure Pipelines successfully started running 1 pipeline(s). |
zjswhhh
approved these changes
Mar 6, 2023
prgeor
reviewed
Mar 6, 2023
| @@ -2232,7 +2236,7 @@ def post_port_mux_info_to_db(logical_port_name, mux_tbl, asic_index, y_cable_tbl | |||
|
|
|||
| for physical_port in physical_port_list: | |||
|
|
|||
| if not y_cable_wrapper_get_presence(physical_port): | |||
| if not y_cable_wrapper_get_presence(physical_port) or cable_type == 'pseudo-cable': | |||
There was a problem hiding this comment.
this is a one-time call to make sure when the gRPC channels/stubs etc are created, ycabled posts the active-standby fields but only as unknown/N/a. The reason for doing it is ST today depends on having this fields populated albeit N/A or unknown, to post the full data to Kusto DB.
this pseudo-cable logic takes care of it, and is only called once when Cable is either inserted/or ycabled spawns
prgeor
approved these changes
Mar 7, 2023
StormLiangMS
pushed a commit
that referenced
this pull request
Mar 7, 2023
…ve' (#341) * [ycable] add changes for correcting telemetry values for 'active-active' This change creates unknown, N/A values for active-standby cable types for active-active type cable. Since streaming telemetry today looks for both active-active and active-standby for posting values to State DB, this change introduces a one time posting of fields with 'pseudo-cable' type when channels are attempted to be created by ycabled. Description Motivation and Context How Has This Been Tested? UT and posting the changes on test device. Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
yxieca
pushed a commit
that referenced
this pull request
Mar 7, 2023
…ve' (#341) * [ycable] add changes for correcting telemetry values for 'active-active' This change creates unknown, N/A values for active-standby cable types for active-active type cable. Since streaming telemetry today looks for both active-active and active-standby for posting values to State DB, this change introduces a one time posting of fields with 'pseudo-cable' type when channels are attempted to be created by ycabled. Description Motivation and Context How Has This Been Tested? UT and posting the changes on test device. Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
AntonHryshchuk
added a commit
to AntonHryshchuk/sonic-buildimage
that referenced
this pull request
Mar 8, 2023
Update sonic-platform-daemons submodule pointer to include the following: * 03374b2 [ycable] add changes for correcting telemetry values for 'active-active' ([sonic-net#341](sonic-net/sonic-platform-daemons#341)) Signed-off-by: AntonHryshchuk <antonh@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change creates
unknown, N/Avalues foractive-standbycable types foractive-activetype cable.Since streaming telemetry today looks for both
active-activeandactive-standbyfor posting values to State DB, this change introduces a one time posting of fields with 'pseudo-cable' type when channels are attempted to be created by ycabled.Description
Motivation and Context
How Has This Been Tested?
UT and posting the changes on test device.
Additional Information (Optional)