Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[201811 xcvrd] state machine enhancement #45

Merged
merged 3 commits into from
Sep 16, 2019
Merged

[201811 xcvrd] state machine enhancement #45

merged 3 commits into from
Sep 16, 2019

Conversation

keboliu
Copy link
Collaborator

@keboliu keboliu commented Sep 4, 2019

backport PR #44 from master to 201811 branch

Enhance the state machine in order to overcome a possible platform temporarily fail/unavailable case

  1. When receiving system_fail event under NORMAL state, it will transmit to INIT instead of exit directly
  2. In INIT state will handle system_fail event as the same as system_not_ready event, try certain times,
    if the system recovered then transmit to NORMAL state again, if not recovered in a certain period, then exit.

the benefit of this change is that when the system has error/failed temporarily, xcvrd can survive and recover instead of exit directly, make to more tolerance to errors.

…l/unavalaible case

    1. When receive system_fail event under NORMAL state, it will transmit to INIT instead of exit directly
    2. In INIT state will handle system_fail event as the same as system_not_ready event,
       try certain times, if system recovered then transmit to NORMAL state again, if not
       covered in a certain period, then exit.
benifit of this change is that when system has error/failed temporarily, xcvrd can survive and recover,
instead of exit directly, make to more tolerence to errors.
@keboliu keboliu changed the title [xcvrd] state machine enhancement [201811 xcvrd] state machine enhancement Sep 4, 2019
sonic-xcvrd/scripts/xcvrd Outdated Show resolved Hide resolved
@keboliu
Copy link
Collaborator Author

keboliu commented Sep 16, 2019

@jleveque comments fixed, would you please have a look?

@jleveque jleveque merged commit d7380c6 into sonic-net:201811 Sep 16, 2019
lguohan pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Sep 17, 2019
@jleveque jleveque added the xcvrd label Jul 10, 2020
vdahiya12 pushed a commit to vdahiya12/sonic-platform-daemons that referenced this pull request Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants