Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xcvrd] Use new logger implementation and enable runtime log level configuration #515

Merged
merged 4 commits into from
Nov 4, 2024
Merged

[xcvrd] Use new logger implementation and enable runtime log level configuration #515

merged 4 commits into from
Nov 4, 2024
+16 −8

Conversation

Junchao-Mellanox
Copy link
Collaborator

@Junchao-Mellanox Junchao-Mellanox commented Jul 18, 2024 •
edited
Loading

Depends on sonic-net/sonic-buildimage#19611

Description

Use new logger class SysLogger and enable runtime log level configuration

Motivation and Context

Use new logger class SysLogger and enable runtime log level configuration

How Has This Been Tested?

Manual test

Additional Information (Optional)

@Junchao-Mellanox Junchao-Mellanox marked this pull request as draft July 18, 2024 02:53
@Junchao-Mellanox
Copy link
Collaborator Author

The checker failure is expected. It should pass after sonic-net/sonic-buildimage#19611 merged.

@prgeor
Copy link
Collaborator

prgeor commented Sep 18, 2024

@Junchao-Mellanox is this PR ready for review? I see in draft mode

@Junchao-Mellanox
Copy link
Collaborator Author

/azpw run Azure.sonic-platform-daemons

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-platform-daemons

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

keboliu
keboliu previously approved these changes Oct 23, 2024
View reviewed changes
@Junchao-Mellanox
Copy link
Collaborator Author

/azpw run Azure.sonic-platform-daemons

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-platform-daemons

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Junchao-Mellanox
Copy link
Collaborator Author

/azpw run Azure.sonic-platform-daemons

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-platform-daemons

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Junchao-Mellanox Junchao-Mellanox marked this pull request as ready for review October 29, 2024 09:27
@Junchao-Mellanox
Copy link
Collaborator Author

/azpw run Azure.sonic-platform-daemons

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-platform-daemons

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Junchao-Mellanox
Copy link
Collaborator Author

The UT failure is caused by dependency miss. The dependency sonic-net/sonic-buildimage#19611 was merged on 10-27.
But there is no vs.master build since 10-25: https://sonic-build.azurewebsites.net/ui/sonic/pipelines/142/builds?branchName=master.

@Junchao-Mellanox
Copy link
Collaborator Author

/azpw run Azure.sonic-platform-daemons

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-platform-daemons

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@keboliu keboliu merged commit 0cb3644 into sonic-net:master Nov 4, 2024
5 checks passed
@Junchao-Mellanox Junchao-Mellanox deleted the master-xcvrd-runtime-log branch November 4, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prgeor prgeor prgeor approved these changes

@keboliu keboliu keboliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Junchao-Mellanox @prgeor @mssonicbld @keboliu