Take non-CMIS xcvrs out of lpmode in SFF Manager #565

peterbailey-arista · 2024-11-21T19:19:48Z

Description

Fix non-CMIS transceivers in down state by bringing them out of low power mode in the SFF Manager Task.
This is intended to work together with the change in sonic-net/sonic-buildimage#20886.

Motivation and Context

Non-CMIS transceivers were not functioning correctly when put into Low Power mode. So XCVRD now brings them out of lpmode.

How Has This Been Tested?

Loaded an image containing this change alongside the change from sonic-net/sonic-buildimage#20886 on an Arista chassis containing a Clearwater2 linecard.
Verified that without this image some interfaces were in a down state but with the image all interfaces came up as expected.

Additional Information (Optional)

linux-foundation-easycla · 2024-11-21T19:19:52Z

The committers listed above are authorized under a signed CLA.

✅ login: peterbailey-arista / name: Peter Bailey (94b96b6)

kenneth-arista · 2024-11-21T21:20:22Z

@arlakshm @wenyiz2021 for awareness

wenyiz2021

LGTM

kenneth-arista · 2024-11-22T02:51:25Z

Yes, along with enabling the SFF manager in xcvrd per platform config ( sonic-net/sonic-buildimage#20886).

…

On Thu, Nov 21, 2024 at 5:57 PM wenyiz2021 ***@***.***> wrote: do we only need this PR for the LP mode causing links down issue? — Reply to this email directly, view it on GitHub <#565 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AWIHIW6M2AJXRJ3DQENRAQ32B2FO3AVCNFSM6AAAAABSHXSQQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJSG4YTGNRQGM> . You are receiving this because you commented.Message ID: ***@***.***>

prgeor · 2024-12-01T14:25:58Z

@mihirpat1 can you please review

prgeor · 2024-12-01T14:39:38Z

sonic-xcvrd/xcvrd/sff_mgr.py

@@ -435,6 +435,8 @@ def task_worker(self):
                    # Skip if these essential routines are not available
                    continue

+                sfp.set_lpmode(False)


@peterbailey-arista I would suggest to use sfp.set_lpmode() only for SFPs that follow SFF8472. All other transceivers like QSFP+, QSFP28 can support lpmode via EEPROM write. The above code expects each platform to implement set_lpmode() even thought that is NOT required for QSFP based modules.

if (SFP type module) { sfp.set_lpmode(False) } else { api = set_lpmode(False) }

After discussing with @byu343 I ended up wrapping api.set_lpmode in a try except instead. Please let me know if this update works for you. Thanks!

mihirpat1 · 2024-12-03T01:37:28Z

sonic-xcvrd/xcvrd/sff_mgr.py

@@ -435,6 +435,12 @@ def task_worker(self):
                    # Skip if these essential routines are not available
                    continue

+                try:
+                    api = sfp.get_xcvr_api()
+                    api.set_lpmode(False)


@peterbailey-arista Per the below implementation, an exception will not be returned for SFF-8472 modules. Can you please handle this accordingly.
https://github.com/sonic-net/sonic-platform-common/blob/0f2e22faccd093a1e5d18235fe119a860be7855e/sonic_platform_base/sonic_xcvr/api/public/sff8472.py#L308

I've now updated it to use sfp.set_lpmode() for only SFPs implementing SFF8472 as was originally suggested

longhuan-cisco · 2024-12-03T22:28:10Z

sonic-xcvrd/xcvrd/sff_mgr.py

@@ -435,6 +435,12 @@ def task_worker(self):
                    # Skip if these essential routines are not available
                    continue

+                try:
+                    api = sfp.get_xcvr_api()


api has been already obtained at the code before:

sonic-platform-daemons/sonic-xcvrd/xcvrd/sff_mgr.py

Line 410 in 78d427e

api = sfp.get_xcvr_api()

mihirpat1 · 2024-12-04T22:37:14Z

sonic-xcvrd/xcvrd/sff_mgr.py

@@ -435,6 +436,11 @@ def task_worker(self):
                    # Skip if these essential routines are not available
                    continue

+                if isinstance(api, Sff8472Api):
+                    sfp.set_lpmode(False)


@peterbailey-arista Can we check for the return value in both the cases and log error if it returns False?
Also, can you please help in fixing the built failure?

I added the check with the new error log. But am not sure how to resolve the build failure, it does not seem to be related to my change. Do you have any suggestions?

kenneth-arista · 2024-12-04T23:44:34Z

/azpw run Azure.sonic-platform-daemons

kenneth-arista · 2024-12-04T23:45:40Z

Above build failure is unrelated to the change in this PR. The failure is caused by:

dpkg: error: cannot access archive 'libnl-3-200_*.deb': No such file or directory

peterbailey-arista · 2024-12-05T00:56:19Z

/azpw run Azure.sonic-platform-daemons

mssonicbld · 2024-12-05T00:56:21Z

/AzurePipelines run Azure.sonic-platform-daemons

azure-pipelines · 2024-12-05T00:56:30Z

Azure Pipelines successfully started running 1 pipeline(s).

longhuan-cisco · 2024-12-05T01:34:20Z

sonic-xcvrd/xcvrd/sff_mgr.py

@@ -435,6 +436,17 @@ def task_worker(self):
                    # Skip if these essential routines are not available
                    continue

+                set_lp_success = (


I assume lpmode handling is only needed at module insertion event, right?

Just some minor suggestion:
Maybe adding below condition check can avoid unnecessary lpmode handling in other cases (e.g. the case of admin_status/host_tx_ready getting changed by config interface shutdown/startup)

if xcvr_inserted: <lpmode logic>

The described scenario unfortunately still requires lpmode set False. If you shutdown then startup the interface without bringing it out of lpmode the interface remains down even if it was up before shutdown

I thought lpmode can get reset after module reset (sfputil reset), but interface shut/start (i.e. NPU/PHY/laser tx ON/OFF) wouldn't impact the module on lpmode/etc unless user/platform/vendor explicitly triggers something additional for module as part of the interface shut/start. Is that not the case here?

My mistake, I believe you are correct. I'll add that change, thanks

peterbailey-arista · 2024-12-06T17:33:14Z

/azpw run Azure.sonic-platform-daemons

mssonicbld · 2024-12-06T17:33:18Z

/AzurePipelines run Azure.sonic-platform-daemons

azure-pipelines · 2024-12-06T17:33:27Z

Azure Pipelines successfully started running 1 pipeline(s).

arlakshm · 2024-12-06T21:34:00Z

/Azp Azure.sonic-platform-daemons

azure-pipelines · 2024-12-06T21:34:05Z

Command 'Azure.sonic-platform-daemons' is not supported by Azure Pipelines. Supported commands help: Get descriptions, examples and documentation about supported commands Example: help "command_name" list: List all pipelines for this repository using a comment. Example: "list" run: Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run. Example: "run" or "run pipeline_name, pipeline_name, pipeline_name" where: Report back the Azure DevOps orgs that are related to this repository and org Example: "where" See additional documentation.

Fix non-CMIS transceivers in down state by bringing them out of lpmode in the SFF Manager Task.

peterbailey-arista · 2024-12-09T20:57:16Z

/azpw run Azure.sonic-platform-daemons

mssonicbld · 2024-12-09T20:57:19Z

/AzurePipelines run Azure.sonic-platform-daemons

azure-pipelines · 2024-12-09T20:57:27Z

Azure Pipelines successfully started running 1 pipeline(s).

arlakshm · 2024-12-13T01:59:06Z

@longhuan-cisco @mihirpat1, Can you please approve this change if all the comments are addressed.

mihirpat1

@peterbailey-arista The changes look good to me. Can you please help in resolving the build failure?

arlakshm · 2024-12-14T01:38:08Z

/Azp run Azure.sonic-platform-daemons

azure-pipelines · 2024-12-14T01:38:17Z

Azure Pipelines successfully started running 1 pipeline(s).

peterbailey-arista mentioned this pull request Nov 21, 2024

Enable SFF Manger on Arista linecards by default sonic-net/sonic-buildimage#20886

Merged

11 tasks

kenneth-arista mentioned this pull request Nov 21, 2024

[chassis T2] link issue aristanetworks/sonic#101

Open

wenyiz2021 approved these changes Nov 22, 2024

View reviewed changes

arlakshm requested a review from prgeor November 22, 2024 21:18

arlakshm added the Request for 202405 Branch label Nov 22, 2024

prgeor requested a review from mihirpat1 December 1, 2024 14:26

prgeor reviewed Dec 1, 2024

View reviewed changes

peterbailey-arista force-pushed the master-sff-lpmode branch from c59fabf to 78d427e Compare December 3, 2024 00:47

mihirpat1 reviewed Dec 3, 2024

View reviewed changes

longhuan-cisco reviewed Dec 3, 2024

View reviewed changes

peterbailey-arista force-pushed the master-sff-lpmode branch from 78d427e to 3d14308 Compare December 4, 2024 22:17

mihirpat1 reviewed Dec 4, 2024

View reviewed changes

peterbailey-arista force-pushed the master-sff-lpmode branch from 3d14308 to 072a3e6 Compare December 4, 2024 23:47

longhuan-cisco reviewed Dec 5, 2024

View reviewed changes

Take non-CMIS xcvrs out of lpmode in SFF Manager

94b96b6

Fix non-CMIS transceivers in down state by bringing them out of lpmode in the SFF Manager Task.

peterbailey-arista force-pushed the master-sff-lpmode branch from 072a3e6 to 94b96b6 Compare December 6, 2024 22:20

mihirpat1 reviewed Dec 13, 2024

View reviewed changes

longhuan-cisco approved these changes Dec 13, 2024

View reviewed changes

longhuan-cisco mentioned this pull request Dec 13, 2024

Update sff_mgr HLD to include high power class enabling and lpmode off sonic-net/SONiC#1867

Open

arlakshm approved these changes Dec 14, 2024

View reviewed changes

arlakshm added the Chassis label Dec 14, 2024

arlakshm merged commit 88d0dd7 into sonic-net:master Dec 14, 2024
5 checks passed

rlhui added the Request for 202411 Branch label Dec 14, 2024

bingwang-ms added the Approved for 202405 Branch label Dec 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Take non-CMIS xcvrs out of lpmode in SFF Manager #565

Take non-CMIS xcvrs out of lpmode in SFF Manager #565

peterbailey-arista commented Nov 21, 2024 •

edited

Loading

linux-foundation-easycla bot commented Nov 21, 2024 •

edited

Loading

kenneth-arista commented Nov 21, 2024

wenyiz2021 left a comment

kenneth-arista commented Nov 22, 2024 via email

prgeor commented Dec 1, 2024

prgeor Dec 1, 2024

peterbailey-arista Dec 3, 2024

mihirpat1 Dec 3, 2024

peterbailey-arista Dec 4, 2024

longhuan-cisco Dec 3, 2024

mihirpat1 Dec 4, 2024

peterbailey-arista Dec 9, 2024

kenneth-arista commented Dec 4, 2024

kenneth-arista commented Dec 4, 2024

peterbailey-arista commented Dec 5, 2024

mssonicbld commented Dec 5, 2024

azure-pipelines bot commented Dec 5, 2024

longhuan-cisco Dec 5, 2024

peterbailey-arista Dec 6, 2024

longhuan-cisco Dec 6, 2024

peterbailey-arista Dec 6, 2024

peterbailey-arista commented Dec 6, 2024

mssonicbld commented Dec 6, 2024

azure-pipelines bot commented Dec 6, 2024

arlakshm commented Dec 6, 2024

azure-pipelines bot commented Dec 6, 2024

peterbailey-arista commented Dec 9, 2024

mssonicbld commented Dec 9, 2024

azure-pipelines bot commented Dec 9, 2024

arlakshm commented Dec 13, 2024

mihirpat1 left a comment

arlakshm commented Dec 14, 2024

azure-pipelines bot commented Dec 14, 2024

Take non-CMIS xcvrs out of lpmode in SFF Manager #565

Take non-CMIS xcvrs out of lpmode in SFF Manager #565

Conversation

peterbailey-arista commented Nov 21, 2024 • edited Loading

Description

Motivation and Context

How Has This Been Tested?

Additional Information (Optional)

linux-foundation-easycla bot commented Nov 21, 2024 • edited Loading

kenneth-arista commented Nov 21, 2024

wenyiz2021 left a comment

Choose a reason for hiding this comment

kenneth-arista commented Nov 22, 2024 via email

prgeor commented Dec 1, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kenneth-arista commented Dec 4, 2024

kenneth-arista commented Dec 4, 2024

peterbailey-arista commented Dec 5, 2024

mssonicbld commented Dec 5, 2024

azure-pipelines bot commented Dec 5, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

peterbailey-arista commented Dec 6, 2024

mssonicbld commented Dec 6, 2024

azure-pipelines bot commented Dec 6, 2024

arlakshm commented Dec 6, 2024

azure-pipelines bot commented Dec 6, 2024

peterbailey-arista commented Dec 9, 2024

mssonicbld commented Dec 9, 2024

azure-pipelines bot commented Dec 9, 2024

arlakshm commented Dec 13, 2024

mihirpat1 left a comment

Choose a reason for hiding this comment

arlakshm commented Dec 14, 2024

azure-pipelines bot commented Dec 14, 2024

peterbailey-arista commented Nov 21, 2024 •

edited

Loading

linux-foundation-easycla bot commented Nov 21, 2024 •

edited

Loading