-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce chassisd to monitor status of cards on chassis #97
Introduce chassisd to monitor status of cards on chassis #97
Conversation
Support of monitoring of line-cards and fabric-cards. This runs in the main thread periodically. Support of handling configuration of moving the cards to administratively up/down state. The handling happens as part of a separate thread that waits on select() for config event.
This pull request introduces 3 alerts when merging e855529 into 1aaffcc - view on LGTM.com new alerts:
|
Additional changes to config-handling as part of another process.
This pull request introduces 4 alerts when merging d82046b into 8507085 - view on LGTM.com new alerts:
|
can we start with python3, also what is the unit test that can be used to test it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add unit tests for chassisd
This pull request introduces 5 alerts when merging 2a1f40b into 61ed24e - view on LGTM.com new alerts:
|
Separated chassisd tasks into ModuleUpdater and ModuleConfigManager classes. UTs are run using Mock platform, chassis and modules on the above classes
Added UT interfacing with Mock classes. |
The missing coverage is mainly around the area of:
However, the functional area has been separated to classes and fully covered. |
@liat-grozovik: Can someone from your team please review? @Staphylo: Can you also review, please? |
I think this daemon should only for the chassis system, so how to prevent it from running on a 1U system? |
With the current implementation, the process will start but gracefully exit if not running for modular chassis. This is not part of critical processes, so should not affect PMON container. |
Change the following key names: - hardwarerev -> hardware_rev - serialnum -> serial - manufacturename -> manufacturer - modelname -> model - Connector -> connector Also fix a typo and some return types in docstrings
Introducing chassisd to monitor status of cards on a modular chassis
HLD: sonic-net/SONiC#646
-What I did
Introducing a new process to monitor status of control, line and fabric cards.
-How I did it
Support of monitoring of line-cards and fabric-cards. This runs in the main thread periodically.
It updates the STATE_DB with the status information. 'show platform chassis-modules' will read from the STATE_DB
Support of handling configuration of moving the cards toadministratively up/down state. The handling happens as part
of a separate thread that waits on select() for config event from a CHASSIS_MODULE table in CONFIG_DB.
-How I verified it