Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read portchannel name from LAG_NAME_MAP_TABLE in COUNTERS_DB #51

Merged
merged 1 commit into from
Nov 19, 2019

Conversation

anilkpandey
Copy link
Contributor

A new COUNTERS_LAG_NAME_MAP table has been added in COUNTERS_DB to keep the portchannel OID to name mapping. This change is to read the portchannel name from this table to display in 'show mac' command when a mac is learnt on a portchannel.

@prsunny
Copy link
Contributor

prsunny commented Nov 19, 2019

Awaiting on the merge of this PR - sonic-net/sonic-buildimage#3770

@prsunny prsunny merged commit 21ebca9 into sonic-net:master Nov 19, 2019
@dzhangalibaba
Copy link
Collaborator

THis change cause build failure on master branch, please double check. @prsunny @stcheng @anilkpandey

I got below error when using latest py-swsssdk submodule , when I move back one commit, then It passed.

tests/test_nexthop.py:44: AssertionError
----------------------------- Captured stdout call -----------------------------
{'trailing_bytes': b'', 'values': [ValueRepresentation(type=<ValueType.NO_SUCH_INSTANCE: 129>, reserved=0, name=ObjectIdentifier(n_subid=14, prefix_=0, include=1, reserved=0, subids=(1, 3, 6, 1, 2, 1, 4, 21, 1, 7, 0, 0, 0, 0)), data=None)], 'error': <Errors.NO_AGENT_X_ERROR: 0>, 'index': 0, 'sys_up_time': 0, 'header': PDUHeader(version=1, type_=<PduTypes.RESPONSE: 18>, flags=16, reserved=0, session_id=42, transaction_id=0, packet_id=0, payload_length=72)}
================ 13 failed, 45 passed, 80 error in 4.68 seconds ================
[ FAIL LOG END ] [ target/python-wheels/asyncsnmp-2.1.0-py3-none-any.whl ]
slave.mk:444: recipe for target 'target/python-wheels/asyncsnmp-2.1.0-py3-none-any.whl' failed
make: *** [target/python-wheels/asyncsnmp-2.1.0-py3-none-any.whl] Error 1
Makefile.work:193: recipe for target 'target/python-wheels/asyncsnmp-2.1.0-py3-none-any.whl' failed
make[1]: *** [target/python-wheels/asyncsnmp-2.1.0-py3-none-any.whl] Error 2
make[1]: Leaving directory '/home/dzhang/MS_DB/sonic-buildimage'
Makefile:6: recipe for target 'target/python-wheels/asyncsnmp-2.1.0-py3-none-any.whl' failed
make: *** [target/python-wheels/asyncsnmp-2.1.0-py3-none-any.whl] Error 2

@anilkpandey
Copy link
Contributor Author

THis change cause build failure on master branch, please double check. @prsunny @stcheng @anilkpandey

I got below error when using latest py-swsssdk submodule , when I move back one commit, then It passed.

tests/test_nexthop.py:44: AssertionError
----------------------------- Captured stdout call -----------------------------
{'trailing_bytes': b'', 'values': [ValueRepresentation(type=<ValueType.NO_SUCH_INSTANCE: 129>, reserved=0, name=ObjectIdentifier(n_subid=14, prefix_=0, include=1, reserved=0, subids=(1, 3, 6, 1, 2, 1, 4, 21, 1, 7, 0, 0, 0, 0)), data=None)], 'error': <Errors.NO_AGENT_X_ERROR: 0>, 'index': 0, 'sys_up_time': 0, 'header': PDUHeader(version=1, type_=<PduTypes.RESPONSE: 18>, flags=16, reserved=0, session_id=42, transaction_id=0, packet_id=0, payload_length=72)}
================ 13 failed, 45 passed, 80 error in 4.68 seconds ================
[ FAIL LOG END ] [ target/python-wheels/asyncsnmp-2.1.0-py3-none-any.whl ]
slave.mk:444: recipe for target 'target/python-wheels/asyncsnmp-2.1.0-py3-none-any.whl' failed
make: *** [target/python-wheels/asyncsnmp-2.1.0-py3-none-any.whl] Error 1
Makefile.work:193: recipe for target 'target/python-wheels/asyncsnmp-2.1.0-py3-none-any.whl' failed
make[1]: *** [target/python-wheels/asyncsnmp-2.1.0-py3-none-any.whl] Error 2
make[1]: Leaving directory '/home/dzhang/MS_DB/sonic-buildimage'
Makefile:6: recipe for target 'target/python-wheels/asyncsnmp-2.1.0-py3-none-any.whl' failed
make: *** [target/python-wheels/asyncsnmp-2.1.0-py3-none-any.whl] Error 2

The following PR needs to be merged as well
sonic-net/sonic-snmpagent#114

@jleveque
Copy link
Contributor

TODO: This PR needs to be cherry-picked into the 201911 branch after sonic-net/sonic-swss#1124 is merged and cherry-picked.

@jleveque
Copy link
Contributor

jleveque commented Mar 5, 2020

This PR was subsequently reverted. However, sonic-net/sonic-swss#1124 has been merged to master. Thus, this PR should be able to be un-reverted from master and also cherry-picked into 201911.

jleveque added a commit that referenced this pull request Mar 20, 2020
jleveque added a commit that referenced this pull request Apr 8, 2020
…TERS_DB (#51)" (#57)" (#64)

This reverts commit 022d8fb.

Add #51 back in by reverting #57, in because issues should be addressed by the merge of sonic-net/sonic-swss#1124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants