Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dual-ToR] update sai.profile with SAI_ADDITIONAL_MAC_ENABLED attribute if corresponding arg passed to syncd #1201

Conversation

ayurkiv-nvda
Copy link
Contributor

@ayurkiv-nvda ayurkiv-nvda commented Feb 4, 2023

Signed-off-by: Andriy Yurkiv ayurkiv@nvidia.com

Update sai.profile with SAI_ADDITIONAL_MAC_ENABLED=1 if "dual_tor" attr is passed to syncd

@ayurkiv-nvda ayurkiv-nvda force-pushed the upstream_dualtor_addition_mac_master branch from 1804940 to 0b73b76 Compare February 7, 2023 22:45
@ayurkiv-nvda ayurkiv-nvda marked this pull request as ready for review February 7, 2023 22:47
stephenxs
stephenxs previously approved these changes Feb 8, 2023
Copy link
Contributor

@stephenxs stephenxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…te if corresponding arg passed to syncd

Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>
@ayurkiv-nvda
Copy link
Contributor Author

Hello @stephenxs
can you approve it again?
Your previous approval was dismissed because of rebase

@ayurkiv-nvda
Copy link
Contributor Author

Hello @prsunny
Can you please take a look?

@ayurkiv-nvda
Copy link
Contributor Author

Hello @bingwang-ms
Can you please take a look?
This PR is similar to #1188

@bingwang-ms
Copy link
Contributor

Hello @bingwang-ms Can you please take a look? This PR is similar to #1188

May I know why do we need this attribute in dualtor scenario?

@ayurkiv-nvda
Copy link
Contributor Author

ayurkiv-nvda commented Feb 24, 2023

Hello @bingwang-ms Can you please take a look? This PR is similar to #1188

May I know why do we need this attribute in dualtor scenario?

Need to add additional MAC to VLAN interface on Mellanox SPC-1. It is impossible on SPC-1, so we just add this additional MAC to FDB table, so traffic forwarding will work.

SAI use this SAI_ADDITIONAL_MAC_ENABLED attribute to make changes per SPC.

@liat-grozovik
Copy link
Collaborator

@saiarcot895 @kcudnik can you please help to merge?

@saiarcot895 saiarcot895 merged commit 886875b into sonic-net:master Feb 27, 2023
yxieca pushed a commit that referenced this pull request Mar 1, 2023
…te if corresponding arg passed to syncd (#1201)

Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>
StormLiangMS pushed a commit that referenced this pull request Mar 7, 2023
…te if corresponding arg passed to syncd (#1201)

Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>
AntonHryshchuk added a commit to AntonHryshchuk/sonic-buildimage that referenced this pull request Mar 8, 2023
Update sonic-sairedis submodule pointer to include the following:
* 749b393 [ci] Fix apt-get install unable locate package issue. ([sonic-net#1212](sonic-net/sonic-sairedis#1212))
* 886875b [Dual-ToR] update sai.profile with SAI_ADDITIONAL_MAC_ENABLED attribute if corresponding arg passed to syncd ([sonic-net#1201](sonic-net/sonic-sairedis#1201))
* c58d259 Use new value of STATE_DB FAST_REBOOT entry ([sonic-net#1196](sonic-net/sonic-sairedis#1196))
* 3808e4c Fix issue: bulk counter feature is disabled ([sonic-net#1205](sonic-net/sonic-sairedis#1205))

Signed-off-by: AntonHryshchuk <antonh@nvidia.com>
dprital added a commit to dprital/sonic-buildimage that referenced this pull request Mar 10, 2023
Update sonic-sairedis submodule pointer to include the following:
* 4bd1dc5 Fast reboot finalizer ([sonic-net#1213](sonic-net/sonic-sairedis#1213))
* 749b393 [ci] Fix apt-get install unable locate package issue. ([sonic-net#1212](sonic-net/sonic-sairedis#1212))
* 886875b [Dual-ToR] update sai.profile with SAI_ADDITIONAL_MAC_ENABLED attribute if corresponding arg passed to syncd ([sonic-net#1201](sonic-net/sonic-sairedis#1201))
* c58d259 Use new value of STATE_DB FAST_REBOOT entry ([sonic-net#1196](sonic-net/sonic-sairedis#1196))
* 3808e4c Fix issue: bulk counter feature is disabled ([sonic-net#1205](sonic-net/sonic-sairedis#1205))

Signed-off-by: dprital <drorp@nvidia.com>
liat-grozovik pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Mar 12, 2023
Update sonic-sairedis submodule pointer to include the following:
* 4bd1dc5 Fast reboot finalizer ([#1213](sonic-net/sonic-sairedis#1213))
* 749b393 [ci] Fix apt-get install unable locate package issue. ([#1212](sonic-net/sonic-sairedis#1212))
* 886875b [Dual-ToR] update sai.profile with SAI_ADDITIONAL_MAC_ENABLED attribute if corresponding arg passed to syncd ([#1201](sonic-net/sonic-sairedis#1201))
* c58d259 Use new value of STATE_DB FAST_REBOOT entry ([#1196](sonic-net/sonic-sairedis#1196))
* 3808e4c Fix issue: bulk counter feature is disabled ([#1205](sonic-net/sonic-sairedis#1205))

Signed-off-by: dprital <drorp@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants