Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202205] Use new value of STATE_DB FAST_REBOOT entry #1217

Merged

Conversation

arfeigin
Copy link
Contributor

@arfeigin arfeigin commented Mar 7, 2023

Dedicated PR for 202205 branch similar to #1213 as part of fast-reboot finalizer implementation.

Update syncd_init_common to check if fast-reboot is enabled according to the new value for FAST_REBOOT entry in STATE_DB.

This PR should come along with the following PRs:
sonic-net/sonic-utilities#2724
sonic-net/sonic-platform-daemons#343
sonic-net/sonic-buildimage#14143

This set of PRs solves the issue sonic-net/sonic-buildimage#13251

@dprital
Copy link
Collaborator

dprital commented Mar 7, 2023

/azpw run

@dprital dprital requested a review from vaibhavhd March 8, 2023 04:44
@arfeigin
Copy link
Contributor Author

arfeigin commented Mar 8, 2023

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@arfeigin
Copy link
Contributor Author

arfeigin commented Mar 8, 2023

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@arfeigin
Copy link
Contributor Author

arfeigin commented Mar 9, 2023

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@arfeigin arfeigin changed the title Use new value of STATE_DB FAST_REBOOT entry [202205] Use new value of STATE_DB FAST_REBOOT entry Mar 9, 2023
@arfeigin
Copy link
Contributor Author

arfeigin commented Mar 9, 2023

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@arfeigin
Copy link
Contributor Author

arfeigin commented Mar 9, 2023

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@arfeigin
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vaibhavhd vaibhavhd merged commit 23ac336 into sonic-net:202205 Mar 10, 2023
vaibhavhd pushed a commit to sonic-net/sonic-utilities that referenced this pull request Mar 10, 2023
…er (#2724)

Dedicated PR for 202205 branch similar to #2621 as part of fast-reboot finalizer implementation.

This should come along with sonic-buildimage PR implementing fast-reboot finalizing logic in finalize-warmboot script and other submodules PRs utilizing the change.

This PR should come along with the following PRs as well:
sonic-net/sonic-sairedis#1217
sonic-net/sonic-platform-daemons#343
sonic-net/sonic-buildimage#14143

This set of PRs solves the issue sonic-net/sonic-buildimage#13251

What I did
Remove the timer used to clear fast-reboot entry from state-db, instead it will be cleared by fast-reboot finalize function implemented inside finalize-warmboot script (which will be invoked since fast-reboot is using warm-reboot infrastructure).

As well instead of having "1" as the value for fast-reboot entry in state-db and deleting it when done it is now modified to set enable/disable according to the context.

As well all scripts reading this entry should be modified to the new value options.

How I did it
Removed the timer usage in the fast-reboot script and adding fast-reboot finalize logic to warm-reboot in the linked PR.
Use "enable: true/false" instead of "1" as the entry value.

How to verify it
Run fast-reboot and check that the state-db entry for fast-reboot is being deleted after finalizing fast-reboot and not by an expiring timer.
dprital added a commit to dprital/sonic-buildimage that referenced this pull request Mar 10, 2023
Update sonic-sairedis submodule pointer to include the following:
* 23ac336 Use new value of STATE_DB FAST_REBOOT entry ([sonic-net#1217](sonic-net/sonic-sairedis#1217))

Signed-off-by: dprital <drorp@nvidia.com>
vaibhavhd pushed a commit to sonic-net/sonic-platform-daemons that referenced this pull request Mar 16, 2023
This PR is similar to #335, dedicated to 202205 branch.

Update xcvrd to check if fast-reboot is enabled according to the new value for FAST_REBOOT entry in STATE_DB.

This PR should come along with the following PRs:
sonic-net/sonic-buildimage#14143
sonic-net/sonic-sairedis#1217
sonic-net/sonic-utilities#2724

This set of PRs solves the issue sonic-net/sonic-buildimage#13251

Description
Update xcvrd to check the updated form of fast-reboot entry in state-db as it was changed.

Motivation and Context
Introducing fast-reboot finalizer on top of warmboot-finalizer, fast-reboot entry in STATE_DB is now changed from "1"/None to "enable: true/false".

How Has This Been Tested?
Existing tests, and fast-reboot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants