Build both the regular and RPC version when the RPC profile is enabled #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the RPC version needs to be built, the regular version of syncd also needs to be built. Unfortunately, this is not easy to do with the current build infra except for manually rerunning configure, removing the built object files/binaries, and building the new config. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
kcudnik
approved these changes
Aug 9, 2023
|
It matches the behavior that was there prior to #1194. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the RPC version needs to be built, the regular version of syncd also needs to be built. Unfortunately, this is not easy to do with the current build infra except for manually rerunning configure, removing the built object files/binaries, and building the new config.