Add synchronous clear_stats operation path #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
|
Need reference pointer advancement to include dcab09f, which has the sai_deserialize_buffer_pool_stat prototype |
syncd Signed-off-by: Wenda Ni <wenni@microsoft.com>
Signed-off-by: Wenda Ni <wenni@microsoft.com>
kcudnik
reviewed
Jun 2, 2019
Signed-off-by: Wenda Ni <wenni@microsoft.com>
kcudnik
reviewed
Jun 4, 2019
the local db Signed-off-by: Wenda Ni <wenni@microsoft.com>
|
please fix compilation issues |
|
retest this please |
|
still compile issue |
Signed-off-by: Wenda Ni <wenni@microsoft.com>
|
✔️ |
lguohan
approved these changes
Jun 8, 2019
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
* Send clear_stats op from orchagent to syncd via Redis pipeline Signed-off-by: Wenda Ni <wenni@microsoft.com> * Handle clear_stats op in syncd Signed-off-by: Wenda Ni <wenni@microsoft.com> * Receive clear_stats op status response from sycnd in orchagent context Signed-off-by: Wenda Ni <wenni@microsoft.com> * Shift clear_stats to get synchronous response from ASIC Signed-off-by: Wenda Ni <wenni@microsoft.com> * Fix compilation error Signed-off-by: Wenda Ni <wenni@microsoft.com> * Fix log message output Signed-off-by: Wenda Ni <wenni@microsoft.com> * Remove debugging symbols Signed-off-by: Wenda Ni <wenni@microsoft.com> * Remove debugging symbols Signed-off-by: Wenda Ni <wenni@microsoft.com> * Change the validation order of KeyOpFieldsValuesTuple responded from syncd Signed-off-by: Wenda Ni <wenni@microsoft.com> * Expand status log utility to include op type as argument Signed-off-by: Wenda Ni <wenni@microsoft.com> * Address comments: check if object id is present in local db Signed-off-by: Wenda Ni <wenni@microsoft.com> * Leverage newly merged infrastructure to check if object id is present in the local db Signed-off-by: Wenda Ni <wenni@microsoft.com> * Fix compile error Signed-off-by: Wenda Ni <wenni@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depend on:
sonic-net/sonic-swss-common#281
Tested on brcm dut
Success story
May 30 18:34:54.871053 str-dx010-acs-1 ERR swss#orchagent: :- internal_redis_generic_clear_stats: generic clear stats key: SAI_OBJECT_TYPE_BUFFER_POOL:oid:0x180000000005b0, fields: 1
May 30 18:34:54.871108 str-dx010-acs-1 ERR swss#orchagent: :- internal_redis_generic_clear_stats: wait for clear_stats response
May 30 18:34:54.871806 str-dx010-acs-1 ERR syncd#syncd: :- processEvent: Receive op: clear_stats
May 30 18:34:54.871806 str-dx010-acs-1 ERR syncd#syncd: :- processClearStatsEvent: Object type SAI_OBJECT_TYPE_BUFFER_POOL, about to clear its stats
May 30 18:34:54.872323 str-dx010-acs-1 ERR swss#orchagent: :- internal_redis_generic_clear_stats: response: key = SAI_STATUS_SUCCESS, op = getresponse
May 30 18:34:54.872623 str-dx010-acs-1 ERR swss#orchagent: :- internal_redis_clear_stats_process: Counter id received SAI_BUFFER_POOL_STAT_WATERMARK_BYTES, expected SAI_BUFFER_POOL_STAT_WATERMARK_BYTES
May 30 18:34:54.872623 str-dx010-acs-1 ERR swss#orchagent: :- internal_redis_generic_clear_stats: generic clear status: SAI_STATUS_SUCCESS
May 30 18:34:54.872623 str-dx010-acs-1 ERR swss#orchagent: :- generateBufferPoolWatermarkCounterIdList: generateBufferPoolCounterIdList: clear_buffer_pool_stats(): SAI_STATUS_SUCCESS
Failure story
May 31 03:08:32.709549 str-a7050-acs-1 ERR swss#orchagent: :- internal_redis_generic_clear_stats: generic clear stats key: SAI_OBJECT_TYPE_BUFFER_POOL:oid:0x180000000005f5, fields: 1
May 31 03:08:32.710267 str-a7050-acs-1 ERR swss#orchagent: :- internal_redis_generic_clear_stats: wait for clear_stats response
May 31 03:08:32.717710 str-a7050-acs-1 ERR syncd#syncd: :- processEvent: Receive op: clear_stats
May 31 03:08:32.717848 str-a7050-acs-1 ERR syncd#syncd: :- processClearStatsEvent: Object type SAI_OBJECT_TYPE_BUFFER_POOL, about to clear its stats
May 31 03:08:32.717952 str-a7050-acs-1 ERR syncd#syncd: :- processClearStatsEvent: Failed to clear stats
May 31 03:08:32.719083 str-a7050-acs-1 ERR swss#orchagent: :- internal_redis_generic_clear_stats: response: key = SAI_STATUS_NOT_SUPPORTED, op = getresponse
May 31 03:08:32.719083 str-a7050-acs-1 ERR swss#orchagent: :- internal_redis_generic_clear_stats: generic clear stats status: SAI_STATUS_NOT_SUPPORTED
May 31 03:08:32.719404 str-a7050-acs-1 ERR swss#orchagent: :- meta_sai_clear_stats_oid: clear status: SAI_STATUS_NOT_SUPPORTED
May 31 03:08:32.719404 str-a7050-acs-1 ERR swss#orchagent: :- generateBufferPoolWatermarkCounterIdList: generateBufferPoolCounterIdList: clear_buffer_pool_stats(): SAI_STATUS_NOT_SUPPORTED