ARM32 bit fixes, for 64bit printf format specifier #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antony Rheneus <arheneus@marvell.com>
Signed-off-by: Antony Rheneus <arheneus@marvell.com>
Signed-off-by: Antony Rheneus <arheneus@marvell.com>
Signed-off-by: Antony Rheneus <arheneus@marvell.com>
jleveque
approved these changes
Jun 11, 2019
lguohan
approved these changes
Jun 14, 2019
kcudnik
approved these changes
Jun 14, 2019
|
why arm is not accepting standard prefixes ? this actually makes code much more messy :/ |
|
@kcudnik: The "PRI..." constants get defined differently depending on the architecture you're compiling for, thus making the code more portable. Some archs define a 64-bit int as a |
|
yea grepped via headers, more portable less readability XD |
|
Yes, unfortunately we sacrifice readability for portability. |
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
* ARM32 bit fixes, for 64bit printf format specifier Signed-off-by: Antony Rheneus <arheneus@marvell.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Antony Rheneus arheneus@marvell.com