syncd cannot be executed using -s option, remove unuseful buffer

[dzhangalibaba]

• fix wrong API type in internal_api_wait_for_response()

• add cmdline parse option "s" , otherwise syncd cannot be executed via -s option, system cannot be up with syncd

  • current behavior:

root@ASW-7005:/# /usr/bin/syncd --diag -u -p /etc/sai.d/sai.profile -s
/usr/bin/syncd: invalid option -- 's'
Usage: syncd [-N] [-U] [-d] [-p profile] [-i interval] [-t [cold|warm|fast|fastfast]] [-h] [-u] [-S] [-s]
    -N --nocounters
        Disable counter thread
    -d --diag
        Enable diagnostic shell
    -p --profile profile
        Provide profile map file
    -i --countersInterval interval
        Provide counter thread interval
    -t --startType type
        Specify cold|warm|fast|fastfast start type
    -u --useTempView:
        Use temporary view between init and apply
    -S --disableExitSleep
        Disable sleep when syncd crashes
    -U --eableUnittests
        Metadata enable unittests
    -C --eableConsistencyCheck
        Enable consisteny check DB vs ASIC after comparison logic
    -s --syncMode
        Enable synchronous mode
    -h --help
        Print out this message

* after the fix :

root@ASW-7005:/# ps -ef | grep syncd
root        56     1  0 07:16 pts/0    00:00:00 /usr/bin/dsserve /usr/bin/syncd --diag -u -p /etc/sai.d/sai.profile -s
root        63    56 20 07:16 pts/0    00:01:50 /usr/bin/syncd --diag -u -p /etc/sai.d/sai.profile -s
root       290    92  0 07:25 pts/2    00:00:00 grep syncd
root@ASW-7005:/# 

• remove unuseful api call g_asicState->setBuffered(false)
  • when orchagent is executed, orchagent will set switch attribute to decide the setBuffer is true or false, it is not needed to set the value here.

Signed-off-by: Dong Zhang d.zhang@alibaba-inc.com

[dzhangalibaba]

is syncd with -s option tested before the changes merged? The issue is obvious.

Also there is another core-dump/crash issue in swss/orchagent when using syncMode, that crash is a must see when loading the image, is orchagent tested before changes merged? I'll file another PR on swss repo for the crash issue.

[kcudnik]

good catch

[lguohan]

can you approve?