WIP: fix vs tests with bulk #694
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytroxshevchuk
changed the title
kcudnik
reviewed
Nov 5, 2020
| @@ -721,7 +721,7 @@ sai_status_t VendorSai::bulkRemove( | |||
| break; | |||
|
|
|||
| default: | |||
| SWSS_LOG_ERROR("not implemented %s, FIXME", sai_serialize_object_type(object_type).c_str()); | |||
| SWSS_LOG_ERROR("not implemented, FIXME"); | |||
| return SAI_STATUS_NOT_IMPLEMENTED; | |||
There was a problem hiding this comment.
please bring back ll the changes in VendorSai.cpp i fixed those in other pr especially SAI_OBJECT_TYPE_NEXT_HOP_GROUP_MEMBER
dmytroxshevchuk
force-pushed
the
fix_vs_tests_with_bulk
branch
from
a0f6876
to
70f1ebc
Compare
…onic-net#685)" This reverts commit 797197c.
This reverts commit b458e6f.
|
is this still avtive? |
Looks like the PR is obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.