[logfile]: Add handling of Sairedis rec filename #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com> Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
|
this will also needs to be handled by sonic syslog rotate, since how it's hardcoded to sairedis.rec i think |
Yes, I will create a PR in sonic-buildimage for logrotate |
|
@kcudnik to approve |
kcudnik
reviewed
Dec 16, 2020
lib/inc/sairedis.h
Outdated
| * | ||
| * @type sai_s8_list_t | ||
| * @flags CREATE_AND_SET | ||
| * @default empty |
There was a problem hiding this comment.
you could make this @default "sairedis.rec"
There was a problem hiding this comment.
address the commit in the latest commit
kcudnik
requested changes
Dec 16, 2020
lib/src/Recorder.cpp
Outdated
|
|
||
| if (attr.value.s8list.count == 0) | ||
| { | ||
| m_recordingFileName = "sairedis.rec"; |
There was a problem hiding this comment.
this name is also used in constructor, can you make a define on top of file and reuse define here ?
There was a problem hiding this comment.
address the commit in the latest commit
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
kcudnik
approved these changes
Dec 18, 2020
This was referenced Dec 28, 2020
Merged
arlakshm
added a commit
to sonic-net/sonic-swss
that referenced
this pull request
Jan 22, 2021
What I did Add new options to specify swss rec and sairedis rec file name. Corresponding change in sairedis sonic-net/sonic-sairedis#747 Why I did it This option will be used in the multi asic system. The swss and sairedis record filename will be different for each asic and will be passed from the orchagent.sh
arlakshm
added a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jan 22, 2021
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan arlakshm@microsoft.com - Why I did it This PR has the changes to support having different swss.rec and sairedis.rec for each asic. The logrotate script is updated as well - How I did it Update the orchagent.sh script to use the logfile name options in these PRs(sonic-net/sonic-swss#1546 and sonic-net/sonic-sairedis#747) In multi asic platforms the record files will be different for each asic, with the format swss.asic{x}.rec and sairedis.asic{x}.rec Update the logrotate script for multiasic platform .
abdosi
pushed a commit
to sonic-net/sonic-swss
that referenced
this pull request
Jan 28, 2021
What I did Add new options to specify swss rec and sairedis rec file name. Corresponding change in sairedis sonic-net/sonic-sairedis#747 Why I did it This option will be used in the multi asic system. The swss and sairedis record filename will be different for each asic and will be passed from the orchagent.sh
abdosi
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jan 28, 2021
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan arlakshm@microsoft.com - Why I did it This PR has the changes to support having different swss.rec and sairedis.rec for each asic. The logrotate script is updated as well - How I did it Update the orchagent.sh script to use the logfile name options in these PRs(sonic-net/sonic-swss#1546 and sonic-net/sonic-sairedis#747) In multi asic platforms the record files will be different for each asic, with the format swss.asic{x}.rec and sairedis.asic{x}.rec Update the logrotate script for multiasic platform .
yxieca
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Feb 23, 2021
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan arlakshm@microsoft.com - Why I did it This PR has the changes to support having different swss.rec and sairedis.rec for each asic. The logrotate script is updated as well - How I did it Update the orchagent.sh script to use the logfile name options in these PRs(sonic-net/sonic-swss#1546 and sonic-net/sonic-sairedis#747) In multi asic platforms the record files will be different for each asic, with the format swss.asic{x}.rec and sairedis.asic{x}.rec Update the logrotate script for multiasic platform .
kktheballer
pushed a commit
to kktheballer/sonic-sairedis
that referenced
this pull request
Feb 25, 2021
The PR implements the handling of the sairedis rec filename passed to the orchagent. Corresponding swss pr : sonic-net/sonic-swss#1546 This change is mainly to be used for multi asic devices where each asic. Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
DavidZagury
pushed a commit
to DavidZagury/sonic-swss
that referenced
this pull request
Mar 4, 2021
What I did Add new options to specify swss rec and sairedis rec file name. Corresponding change in sairedis sonic-net/sonic-sairedis#747 Why I did it This option will be used in the multi asic system. The swss and sairedis record filename will be different for each asic and will be passed from the orchagent.sh
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
What I did Add new options to specify swss rec and sairedis rec file name. Corresponding change in sairedis sonic-net/sonic-sairedis#747 Why I did it This option will be used in the multi asic system. The swss and sairedis record filename will be different for each asic and will be passed from the orchagent.sh
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
The PR implements the handling of the sairedis rec filename passed to the orchagent. Corresponding swss pr : sonic-net/sonic-swss#1546 This change is mainly to be used for multi asic devices where each asic. Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR implements the handling of the sairedis rec filename passed to the orchagent.
Coresponding swss pr : sonic-net/sonic-swss#1546
This change is mainly to be used for multi asic devices where each asic.