-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] debian/conffiles will give prompt if file existing when installing , need a way to supress prompt #323
Conversation
@qiluo-msft FYI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Block this until we make change in sonic-slave (sonic-net/sonic-buildimage#3879) to prevent prompt
@@ -1,3 +1,4 @@ | |||
usr/lib/*/lib*.so.* | |||
usr/share/swss/*.lua | |||
var/run/redis/sonic-db/database_config.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var run usually hold running states, not configuration. why not /etc/sonic/redis/sonic-db/database_config.json.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me try to clarify the reason:
It is the database docker's responsibility to read startup configuration, and generate running configuration. All the downstream components read the "running configuration", and this one is an example.
…eed a way to supress prompt
98143bb
to
a203752
Compare
@qiluo-msft ready for review since sonic-net/sonic-buildimage#3879 is already merged. |
I suggest we merge this change until the latest slave-docker is built and used for building, otherwise it may break the build cause of the prompt. |
…eed a way to supress prompt (#323)
Signed-off-by: Dong Zhang d.zhang@alibaba-inc.com