-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVPN VXLAN DB support #339
Conversation
common/schema.h
Outdated
#define STATE_VXLAN_TUNNEL_TABLE_NAME "VXLAN_TUNNEL_TABLE" | ||
|
||
|
||
#define STATE_TUNNEL_VLAN_MAP_TABLE_NAME "TUNNEL_VLAN_MAP_TABLE" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rename this to VXLAN_TUNNEL_MAP.. to be in consistent with CFG_VXLAN_TUNNEL_MAP_TABLE_NAME
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This table is related to Neighbor suppression changes. Will modify the name.
Will this name "STATE_NEIGH_SUPRESS_VLAN_TABLE_NAME" be fine ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
@srj102 , can you rebase and address any outstanding comments. |
@srj102 , lets get this PR marked for ready. Also, have only the evpn attributes in this PR. I see some changes related to warmboot etc. That can be in another PR. |
This is in accordance with the HLD as part of the following PR. sonic-net/SONiC#437 CONFIG DB 1. EVPN_NVO Table. APP DB 1. EVPN_REMOTE_VNI Table. 2. VXLAN_FDB Table. STATE DB 1. VXLAN_TUNNEL Table.
to allow for compilation of the PR sonic-net/sonic-swss#1264
common/schema.h
Outdated
@@ -38,6 +38,10 @@ namespace swss { | |||
#define APP_VXLAN_VRF_TABLE_NAME "VXLAN_VRF_TABLE" | |||
#define APP_VXLAN_TUNNEL_MAP_TABLE_NAME "VXLAN_TUNNEL_MAP_TABLE" | |||
#define APP_VXLAN_TUNNEL_TABLE_NAME "VXLAN_TUNNEL_TABLE" | |||
#define APP_VXLAN_FDB_TABLE_NAME "VXLAN_FDB_TABLE" | |||
#define APP_VXLAN_REMOTE_VNI_TABLE_NAME "VXLAN_REMOTE_VNI_TABLE" | |||
#define APP_EVPN_NVO_TABLE_NAME "VXLAN_EVPN_NVO_TABLE" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on previous comment, it should have been APP_EVPN_NVO_TABLE_NAME -> APP_VXLAN_EVPN_NVO_TABLE_NAME to be consistent with CFG_VXLAN_EVPN_NVO_TABLE_NAME
common/schema.h
Outdated
@@ -251,6 +257,8 @@ namespace swss { | |||
#define STATE_NEIGH_RESTORE_TABLE_NAME "NEIGH_RESTORE_TABLE" | |||
#define STATE_MIRROR_SESSION_TABLE_NAME "MIRROR_SESSION_TABLE" | |||
#define STATE_VXLAN_TABLE_NAME "VXLAN_TABLE" | |||
#define STATE_VXLAN_TUNNEL_TABLE_NAME "VXLAN_TUNNEL_TABLE" | |||
#define STATE_NEIGH_SUPPRESS_VLAN_TABLE_NAME "NEIGH_SUPPRESS_VLAN_MAP_TABLE" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a mismatch here w.r.t APP DB - "NEIGH_SUPPRESS_VLAN_MAP_TABLE" -> "SUPPRESS_VLAN_NEIGH_TABLE". Can you please correct this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Added support for new VXLAN DBs as described in the PR sonic-net/SONiC#437