Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIs to support streaming structured events #667

Merged
merged 120 commits into from
Aug 10, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
120 commits
Select commit Hold shift + click to select a range
d883c01
first cut
renukamanavalan May 13, 2022
c223d04
first cut lib code with unit test
renukamanavalan May 14, 2022
7fbdcf1
save it just in case, as VM under risk
renukamanavalan May 17, 2022
9763d3a
partial update, as vm at risk
renukamanavalan May 17, 2022
d9d24b6
intermediate saving
renukamanavalan May 18, 2022
d68c204
First run code complete
renukamanavalan May 19, 2022
d130b84
self review update
renukamanavalan May 20, 2022
63db87a
partial compile
renukamanavalan May 21, 2022
cc2bfe5
In middle of compilation
renukamanavalan May 23, 2022
d28399e
compiled OK
renukamanavalan May 23, 2022
f2694ea
common ut passes
renukamanavalan May 24, 2022
4c8373d
events_service unit tests complete
renukamanavalan May 24, 2022
2197e85
test code in progress
renukamanavalan May 25, 2022
67fbe19
evens publish covere by unit test
renukamanavalan May 26, 2022
9d64634
events 75% covered by UT
renukamanavalan May 27, 2022
e7f1bca
subscribe UT done
renukamanavalan May 31, 2022
2f13706
Merge remote-tracking branch 'origin/syslog_telemetry_shared' into re…
renukamanavalan May 31, 2022
94153f5
Drop internal readme
renukamanavalan May 31, 2022
c4db46e
Update upon self review - mostly on comments
renukamanavalan May 31, 2022
e81160b
More on comments update
renukamanavalan May 31, 2022
9f7b2a8
minor fix of copy/paste error
renukamanavalan May 31, 2022
35a6030
Comments update
renukamanavalan May 31, 2022
6eb78d7
more comments
renukamanavalan May 31, 2022
3328970
minor updates; merged with master via shared
renukamanavalan May 31, 2022
66632f6
Per review comments
renukamanavalan Jun 2, 2022
c849258
Merge pull request #1 from renukamanavalan/remanava_events
renukamanavalan Jun 2, 2022
9ba11ed
minor updates
renukamanavalan Jun 7, 2022
d1a6f83
minor: name change for a typedef
renukamanavalan Jun 9, 2022
bd28ea8
Added EXIT code
renukamanavalan Jun 10, 2022
8f72258
Minor name change; Enabled py build for events
renukamanavalan Jun 14, 2022
2f9e3cc
Merge pull request #2 from renukamanavalan/remanava_events
renukamanavalan Jun 17, 2022
ce606d4
Minor signature update to adapt to SWIG generated python
renukamanavalan Jun 17, 2022
b0d7ee0
Made zmq send & receive thread safe
renukamanavalan Jun 20, 2022
c71e7f0
Merge pull request #3 from renukamanavalan/remanava_events
renukamanavalan Jun 21, 2022
ee8e79e
temp commit to enable merge
renukamanavalan Jul 5, 2022
302aba7
Merge remote-tracking branch 'upstream/master' into syslog_telemetry_…
renukamanavalan Jul 5, 2022
bcfb876
Merge remote-tracking branch 'origin/syslog_telemetry_shared' into re…
renukamanavalan Jul 5, 2022
ca8d5b5
removed hacks; Added set log level API
renukamanavalan Jul 8, 2022
0365b3d
Minor signature change
renukamanavalan Jul 8, 2022
daf2ced
Added unit test for C wrap
renukamanavalan Jul 11, 2022
8c42e85
Corrected per review comments; Addede log message for published events
renukamanavalan Jul 12, 2022
089864e
Merge pull request #4 from renukamanavalan/remanava_events
renukamanavalan Jul 13, 2022
cf30d4b
minor updates;no logical code changes
renukamanavalan Jul 15, 2022
48a36ce
Merge pull request #5 from renukamanavalan/remanava_events
renukamanavalan Jul 15, 2022
b587963
corrected per review comments; Added accidentally removed test
renukamanavalan Jul 18, 2022
6bebad3
Added back accidentally removed test code file
renukamanavalan Jul 18, 2022
98fb238
Merge branch 'syslog_telemetry_shared' of https://github.com/renukama…
renukamanavalan Jul 18, 2022
94d9c23
retire runtime id on deinit
renukamanavalan Jul 19, 2022
87bee63
Merge remote-tracking branch 'origin/syslog_telemetry_shared' into st…
renukamanavalan Jul 19, 2022
aa45b1b
restore accidental removal
renukamanavalan Jul 19, 2022
e083c42
Merge remote-tracking branch 'origin/syslog_telemetry_shared' into st…
renukamanavalan Jul 19, 2022
d7cbbd8
Merge remote-tracking branch 'upstream/master' into syslog_telemetry_…
renukamanavalan Jul 20, 2022
f72d159
Merge remote-tracking branch 'origin/syslog_telemetry_shared' into re…
renukamanavalan Jul 21, 2022
5e1e281
Switched to shared_ptr per review comments
renukamanavalan Jul 21, 2022
7bbce0a
minor non logical code changes
renukamanavalan Jul 21, 2022
00705eb
Merge pull request #6 from renukamanavalan/remanava_events
renukamanavalan Jul 21, 2022
a0587a0
fix syntax
renukamanavalan Jul 21, 2022
3169a4d
few follow up changes for bare ptr to shared ptr conversion
renukamanavalan Jul 21, 2022
509d536
merged with shared
renukamanavalan Jul 21, 2022
f1a6510
send event as JSON string
renukamanavalan Jul 22, 2022
72d079e
syntax
renukamanavalan Jul 22, 2022
9e4b7db
syntax
renukamanavalan Jul 22, 2022
1428c18
syntax
renukamanavalan Jul 22, 2022
3e330d7
syntax
renukamanavalan Jul 22, 2022
8e0553b
syntax
renukamanavalan Jul 22, 2022
8ff311f
compile fix
renukamanavalan Jul 22, 2022
a560586
compile fix
renukamanavalan Jul 22, 2022
8c99651
compile fix
renukamanavalan Jul 22, 2022
de179f3
compile fix
renukamanavalan Jul 22, 2022
100ece7
compile fix
renukamanavalan Jul 22, 2022
3887e61
compile fix
renukamanavalan Jul 22, 2022
c6fdd80
compile fix
renukamanavalan Jul 22, 2022
88156a1
compile fix
renukamanavalan Jul 22, 2022
9fcf2f0
changing wrap signature to use struct instead of JSON string
renukamanavalan Jul 26, 2022
f50f878
compile fix
renukamanavalan Jul 26, 2022
5e9b4c3
compile fix
renukamanavalan Jul 26, 2022
68da0df
compile fix
renukamanavalan Jul 26, 2022
c997fc5
compile fix
renukamanavalan Jul 26, 2022
6bb9f33
compile fix
renukamanavalan Jul 26, 2022
80eda6e
compile fix
renukamanavalan Jul 26, 2022
ed32576
compile fix
renukamanavalan Jul 26, 2022
d1f960c
compile fix
renukamanavalan Jul 26, 2022
00fa3a3
compile fix
renukamanavalan Jul 26, 2022
948ae40
compile fix
renukamanavalan Jul 26, 2022
96945eb
compile fix
renukamanavalan Jul 26, 2022
a6d38ad
compile fix
renukamanavalan Jul 26, 2022
f07adc4
compile fix
renukamanavalan Jul 26, 2022
c3f06cc
compile fix
renukamanavalan Jul 26, 2022
4d6f3f6
compile fix
renukamanavalan Jul 26, 2022
d3475cc
compile fix
renukamanavalan Jul 26, 2022
4ee2050
compile fix
renukamanavalan Jul 26, 2022
33cd34e
compile fix
renukamanavalan Jul 27, 2022
972fa62
compile fix
renukamanavalan Jul 28, 2022
3ccb824
compile fix
renukamanavalan Jul 28, 2022
540dc70
Merge remote-tracking branch 'upstream/master' into syslog_telemetry_…
renukamanavalan Jul 29, 2022
bb777f3
compile fix
renukamanavalan Jul 29, 2022
13a7f5c
compile fix
renukamanavalan Jul 30, 2022
07cff7e
compile fix
renukamanavalan Jul 30, 2022
aa9c3fe
Add libzmq5 as dependency for ubuntu-20.04 build (#7)
zbud-msft Aug 2, 2022
d81441b
Modify azp (#8)
zbud-msft Aug 2, 2022
6b79a20
Modify azp (#9)
zbud-msft Aug 2, 2022
40f0665
Modify azp (#10)
zbud-msft Aug 3, 2022
30f49d9
Merge branch 'sonic-net:master' into syslog_telemetry_shared
zbud-msft Aug 3, 2022
0f58397
Merge remote-tracking branch 'origin/syslog_telemetry_shared' into st…
renukamanavalan Aug 3, 2022
fe863a7
compile errors
renukamanavalan Aug 4, 2022
3c8e1f0
compile errors
renukamanavalan Aug 4, 2022
36e18f7
Compile error from Ubuntu
renukamanavalan Aug 4, 2022
fc65a91
drop unused macro
renukamanavalan Aug 4, 2022
0ff6c10
compile fix
renukamanavalan Aug 4, 2022
4d24e6f
compile fix
renukamanavalan Aug 4, 2022
e3db7b8
remove pedantic
renukamanavalan Aug 4, 2022
2dab4e8
restored ABORT_IF_NOT
renukamanavalan Aug 4, 2022
7546a87
revert flag add
renukamanavalan Aug 4, 2022
6de2566
comments correction
renukamanavalan Aug 6, 2022
fd18ca8
Merge pull request #13 from renukamanavalan/statistics
renukamanavalan Aug 8, 2022
7fd1e4a
Log every published event
renukamanavalan Aug 8, 2022
7976914
Merge pull request #14 from renukamanavalan/statistics
renukamanavalan Aug 8, 2022
ded4178
Install dependencies for vstest (#15)
zbud-msft Aug 9, 2022
3351061
Install deps vstest (#16)
zbud-msft Aug 9, 2022
7e8d47c
Install deps vstest (#17)
zbud-msft Aug 9, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .azure-pipelines/build_and_install_module.sh
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ function build_and_install_kmodule()
apt-get install -y build-essential linux-headers-${KERNEL_RELEASE} autoconf pkg-config fakeroot
apt-get install -y flex bison libssl-dev libelf-dev
apt-get install -y libnl-route-3-200 libnl-route-3-dev libnl-cli-3-200 libnl-cli-3-dev libnl-3-dev
# Install libs required by libswsscommon
apt-get install -y libzmq3-dev libzmq5 libboost-serialization1.71.0 uuid-dev

# Add the apt source mirrors and download the linux image source code
cp /etc/apt/sources.list /etc/apt/sources.list.bk
Expand Down
2 changes: 1 addition & 1 deletion BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ cc_library(
includes = [
"common",
],
linkopts = ["-lpthread -lhiredis -lnl-genl-3 -lnl-nf-3 -lnl-route-3 -lnl-3"],
linkopts = ["-lpthread -lhiredis -lnl-genl-3 -lnl-nf-3 -lnl-route-3 -lnl-3 -lzmq -lboost_serialization -luuid"],
visibility = ["//visibility:public"],
)

Expand Down
2 changes: 1 addition & 1 deletion azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ stages:
sudo apt-get update
sudo apt-get install -y make libtool m4 autoconf dh-exec debhelper cmake pkg-config \
libhiredis-dev libnl-3-dev libnl-genl-3-dev libnl-route-3-dev libnl-nf-3-dev swig3.0 \
libpython2.7-dev libboost-dev libboost1.71-dev
libpython2.7-dev libboost-dev libboost1.71-dev libboost-serialization-dev uuid-dev libzmq5 libzmq3-dev
sudo apt-get install -y sudo
sudo apt-get install -y redis-server redis-tools
sudo apt-get install -y python3-pip
Expand Down
5 changes: 4 additions & 1 deletion common/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ DBGFLAGS = -g -DNDEBUG
endif

libswsscommon_la_SOURCES = \
events_common.cpp \
events_service.cpp \
events.cpp \
logger.cpp \
redisreply.cpp \
configdb.cpp \
Expand Down Expand Up @@ -71,7 +74,7 @@ libswsscommon_la_SOURCES = \

libswsscommon_la_CXXFLAGS = $(DBGFLAGS) $(AM_CFLAGS) $(CFLAGS_COMMON) $(LIBNL_CFLAGS) $(CODE_COVERAGE_CXXFLAGS)
libswsscommon_la_CPPFLAGS = $(DBGFLAGS) $(AM_CFLAGS) $(CFLAGS_COMMON) $(LIBNL_CPPFLAGS) $(CODE_COVERAGE_CPPFLAGS)
libswsscommon_la_LIBADD = -lpthread $(LIBNL_LIBS) $(CODE_COVERAGE_LIBS)
libswsscommon_la_LIBADD = -lpthread $(LIBNL_LIBS) $(CODE_COVERAGE_LIBS) -lzmq -lboost_serialization -luuid

swssloglevel_SOURCES = loglevel.cpp

Expand Down
Loading