Return both DEL and SET requests in ConsumerStateTable pops() when both types of requests are queued. #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
both types of requests are queued. Before this change, it will only return the SET request. The DEL request is lost which can cause issues in some scenarios. Bug: 304818797 Sanity-Workflow: https://fusion2.corp.google.com/4ae50929-4d85-3bd3-8f65-5cd8a5690761 Change-Id: I0e87185468cd12cbf978941c458393437e7f79d4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, it will only return the SET request if both DEL and SET requests are queued (DEL followed by SET). The DEL request is lost which can cause issues in some scenarios where there are multiple clients write to the same APPL DB table.