[CRM] Safety check for division by 0 (#1569)

Check if divisor is 0. If yes, log warning and skip division
sonic-net · Feb 17, 2021 · 44ffe5c · 44ffe5c
1 parent 6055853
commit 44ffe5c
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/orchagent/crmorch.cpp b/orchagent/crmorch.cpp
@@ -540,7 +540,16 @@ void CrmOrch::checkCrmThresholds()
 
             if (cnt.usedCounter != 0)
             {
-                percentageUtil = (uint32_t)((cnt.usedCounter * 100) / (uint64_t)(cnt.usedCounter + cnt.availableCounter));
+                uint32_t dvsr = cnt.usedCounter + cnt.availableCounter;
+                if (dvsr != 0)
+                {
+                    percentageUtil = (cnt.usedCounter * 100) / dvsr;
+                }
+                else
+                {
+                    SWSS_LOG_WARN("%s Exception occured (div by Zero): Used count %u free count %u",
+                                  res.name.c_str(), cnt.usedCounter, cnt.availableCounter);
+                }
             }
 
             switch (res.thresholdType)