Skip to content

Commit

Permalink
Remove TODO comments that are no longer relevant (#2622)
Browse files Browse the repository at this point in the history
I removed TODO comments that are no longer relevant. To clean source code, non relevant comments should be cleared from source.
  • Loading branch information
liorghub authored Jan 18, 2023
1 parent d058390 commit a01470f
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 11 deletions.
2 changes: 0 additions & 2 deletions cfgmgr/intfmgrd.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@ int main(int argc, char **argv)
WarmStart::checkWarmStart("intfmgrd", "swss");

IntfMgr intfmgr(&cfgDb, &appDb, &stateDb, cfg_intf_tables);

// TODO: add tables in stateDB which interface depends on to monitor list
std::vector<Orch *> cfgOrchList = {&intfmgr};

swss::Select s;
Expand Down
2 changes: 0 additions & 2 deletions cfgmgr/portmgrd.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,6 @@ int main(int argc, char **argv)
DBConnector stateDb("STATE_DB", 0);

PortMgr portmgr(&cfgDb, &appDb, &stateDb, cfg_port_tables);

// TODO: add tables in stateDB which interface depends on to monitor list
vector<Orch *> cfgOrchList = {&portmgr};

swss::Select s;
Expand Down
1 change: 0 additions & 1 deletion cfgmgr/vrfmgrd.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ int main(int argc, char **argv)

isWarmStart = WarmStart::isWarmStart();

// TODO: add tables in stateDB which interface depends on to monitor list
std::vector<Orch *> cfgOrchList = {&vrfmgr};

swss::Select s;
Expand Down
5 changes: 0 additions & 5 deletions orchagent/qosorch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1338,11 +1338,6 @@ task_process_status QosOrch::handleSchedulerTable(Consumer& consumer, KeyOpField
attr.value.u8 = (uint8_t)stoi(fvValue(*i));
sai_attr_list.push_back(attr);
}
else if (fvField(*i) == scheduler_priority_field_name)
{
// TODO: The meaning is to be able to adjust priority of the given scheduler group.
// However currently SAI model does not provide such ability.
}
else if (fvField(*i) == scheduler_meter_type_field_name)
{
sai_meter_type_t meter_value = scheduler_meter_map.at(fvValue(*i));
Expand Down
1 change: 0 additions & 1 deletion orchagent/qosorch.h
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ const string scheduler_algo_DWRR = "DWRR";
const string scheduler_algo_WRR = "WRR";
const string scheduler_algo_STRICT = "STRICT";
const string scheduler_weight_field_name = "weight";
const string scheduler_priority_field_name = "priority";
const string scheduler_meter_type_field_name = "meter_type";
const string scheduler_min_bandwidth_rate_field_name = "cir";//Committed Information Rate
const string scheduler_min_bandwidth_burst_rate_field_name = "cbs";//Committed Burst Size
Expand Down

0 comments on commit a01470f

Please sign in to comment.