FDB entries are not flushed before remove_bridge_port #304
Labels
Comments
|
Hello, this is a known issue. The ASIC SDK doesn't have the responsibility of deleting the FDB entries. This issue needs to be addressed otherwise while removing the bridge port, the saimetadata will complain about that there're still objects referencing this bridge port. |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this issue
Feb 28, 2022
del is a keyword in Python Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this issue
Mar 1, 2023
* initial barefoot checkin october 2017 * Revert "Merge branch 'master' of https://github.com/Azure/sonic-sairedis into rel_6_0" This reverts commit c48a7a20de2fb9e615535481f8727029440413bc, reversing changes made to aa5bf640db7b7fca245c1669eeb02198a50cb5c1. * missed integration diffs * Added new attr type support to sairedis. Also, some fixes for compilation issues * Changes to add new DTel api support in sairedis * Add new file to generate Dtel specific SAI stub API * Missed adding a file in the last commit * Fix ref point for SAI * Updated SAI repo to point to dtel_exp * Changes to handle new additions to DTel experimental SAI. Not compiled yet * handle platform specific lins in different directory (@runtime) * force order of library path to look for platform dir before lib dir * Change SAI branch refpoint * Update SAI submodule refpoint * enable fast-boot for barefoot platforms * Update ref point for SAI * SONiC changes due to DTel experimental SAI changes * allow Makefile to build for other platforms - restore it original for non-bfn platforms * allow clean build * Revert "allow clean build" This reverts commit adfdb8642fe0b5dbb4e19d13871172a03a8c883b. * Revert "allow Makefile to build for other platforms - restore it original for non-bfn platforms" This reverts commit d6b0ca34fcf63d0b79c801cd95d7ee2fe58d21ac. * makefile cleanup towards upstream * Support for platforms based on Barefoot Networks' device (sonic-net#304) * search for exact string - newer onie versions match multiple lines * Will need to revert this Should work without this change. Untested for now * SONiC sairedis changes needed to work with SAIv1.3 * Fix SAI path in gitmodules and add a comment * Remove sai thrift build hack * enable fast-boot for barefoot platforms * enable fast-boot for barefoot platforms * Add missing sai rpc hdr file path for bfn * Update SAI ref points * Multi p4 profile support for bfn sde (#5) * Remove code duplicated in merge * Keep fn in same order as azure master (sonic-net#8) * Address review comment * Link just bfn sai lib and shorten linking command by removing other libraries linked at compile time (#6) * Link only bfn sai lib * all unresolved symbols resolved at runtime * Preload some bfn libraries on syncd startup * Build fix * also remove commented code * Convert tabs to spaces * Fix alignment * Address upstream comment * BFN: link with just sai library for saisdkdump * Address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Based on the declaration in SAI/inc/saibridge.h, it's understood that before remove_bridge_port all the associated FDB entries are supposed to be deleted first.
However in current portsorch.cpp, the deletion is left TBD as shown in this line https://github.com/Azure/sonic-swss/blob/v1.0.3/orchagent/portsorch.cpp#L1195
I would like to know what the impact of not deleting FDB would be?
If SONiC is not going to delete it, is this ASIC SDK's responsibility to delete it when setting admin state to DOWN or when handling the remove_bridge_port request?
Thanks!
The text was updated successfully, but these errors were encountered: