Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What is the valid prefix of vrf_name? "Vrf" or "vrf"? #940

Closed
shikenghua opened this issue Jun 18, 2019 · 2 comments
Closed

What is the valid prefix of vrf_name? "Vrf" or "vrf"? #940

shikenghua opened this issue Jun 18, 2019 · 2 comments

Comments

@shikenghua
Copy link
Contributor

In VRF HLD, it says that vrf_must start with "Vrf". The examples in this document also follow this format.

"vrf_name":"Vrf-blue"  // vrf_name must start with "Vrf" prefix

But test_vrf.py use "vrf" as vrf_name prefix. Currently, sonic-swss doesn't validate vrf_name, so the pytest will still pass.

state = vrf_create(asic_db, appl_db, "vrf1",

Which one is correct? Thanks.
@shine4chen
Copy link
Contributor

test_vrf.py have been refined per VRF HLD requirement. You can find it In [VRF]: submit vrf feature #392 #943

@shikenghua
Copy link
Contributor Author

Got it. Thank you.

EdenGri pushed a commit to EdenGri/sonic-swss that referenced this issue Feb 28, 2022
@FuzailBrcm
[PDDF] Make utilities compatible to platform API 2.0, in accordance w…
e17383a 
…ith pddf_2.0 (sonic-net#940)

Added PDDF utilities changes to make them compatible with 2.0 platform APIs. Since PDDF 2.0 is supporting platform 2.0 APIs, we needed to move the utilities to support the same.

Signed-off-by: Fuzail Khan <fuzail.khan@broadcom.com>
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this issue Mar 1, 2023
@kcudnik
[unittest] Add NotificationBfdSessionStateChange tests (sonic-net#940)
89d639b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shine4chen @shikenghua