[neighorch]: Return false when the next hop IP exists before adding #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsunny
reviewed
Sep 3, 2019
| @@ -30,6 +30,13 @@ bool NeighOrch::addNextHop(IpAddress ipAddress, string alias) | |||
| { | |||
| SWSS_LOG_ENTER(); | |||
|
|
|||
| if (hasNextHop(ipAddress)) | |||
There was a problem hiding this comment.
Do you want to take care of out-of-sequence in the delete case as well?
There was a problem hiding this comment.
any update on this @stcheng ?
It is possible that due to events reordering, a different next hop entry with same IP will be inserted before the previous next hop entry gets removed. Thus, return false here to prevent the new entry from replacing the old one automatically. Update the symmetric removeNextHop() function as well. Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
|
updated |
|
Since the pull request #977 could fix this issue ultimately, this pull request will be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible that due to events reordering, a different next hop
entry with same IP will be inserted before the previous next hop
entry gets removed. Thus, return false here to prevent the new entry
from replacing the old one automatically.
Signed-off-by: Shu0T1an ChenG shuche@microsoft.com